public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: "Mukker, Atul" <Atulm@lsil.com>
Cc: 'Christoph Hellwig' <hch@infradead.org>,
	"'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>
Subject: RE: [ANNOUNCE]: megaraid driver version 2.20.0.1
Date: 21 Jul 2004 12:06:15 -0500	[thread overview]
Message-ID: <1090429579.1951.13.camel@mulgrave> (raw)
In-Reply-To: <0E3FA95632D6D047BA649F95DAB60E57033BC89C@exa-atlanta>

On Wed, 2004-07-21 at 08:48, Mukker, Atul wrote:
> > The philosophy for scsi drivers for a while has been to 
> > remove internal
> > queueing, which is why yours attracted my attention, so the question I
> > was asking is can you use these APIs instead of having to 
> > maintain this
> > internal queue?
> The internal pending queue is fed not only from the mid-layer packets but
> also the packets from the management module and (forthcoming) sysfs module.
> Both of these modules rely on the fact that the commands issued by them
> would be issued sooner or later.

Hmm, well, in order to re-use the block layer queueing, you can wrap
these up into special requests and queue them as well.  The actual SCSI
implementation does do a head of queue add, so any request so queued is
the first to be pulled off again and executed

> In addition, in certain situations (logical drive deletion) driver has to
> stop sending commands to the FW before these operations can be initiated.
> This is also implemented using the pending queue mechanism. Although would
> be minor change to move over to scsi_block_requests and scsi_unblock_request
> to achieve this.
> 
> This is not to say that I am reluctant to implement SCSI_MLQUEUE_HOST_BUSY,
> but just a precursor where additional impacts would be so that reviewers can
> focus on those areas as well.

Well, OK, just do the changes to get rid of yield, and we can look at
fixing the queuing in tree.

James



  reply	other threads:[~2004-07-21 17:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-21 13:48 [ANNOUNCE]: megaraid driver version 2.20.0.1 Mukker, Atul
2004-07-21 17:06 ` James Bottomley [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-07-20 21:21 Mukker, Atul
2004-07-20 21:56 ` James Bottomley
2004-07-06 18:32 Mukker, Atul
2004-07-06 20:56 ` James Bottomley
2004-06-26  0:55 Mukker, Atul
2004-07-06 14:46 ` James Bottomley
2004-06-25  9:07 Mukker, Atul
2004-06-25  1:07 Mukker, Atul
2004-06-25  8:13 ` 'Christoph Hellwig'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1090429579.1951.13.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=Atulm@lsil.com \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox