[PATCH] fix the fix for multiple HBA problem with transport classes

[PATCH] fix the fix for multiple HBA problem with transport classes

[James.Smart]

Testing was showing transport devices not being enumerated.

The reason was the wrong attribute container was being compared
against in the "match" functions.  This patch fixes it.

-- james s


diff -puN a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
--- a/drivers/scsi/scsi_transport_fc.c	2005-02-02 14:49:15.000000000 -0500
+++ b/drivers/scsi/scsi_transport_fc.c	2005-02-02 15:31:47.000000000 -0500
@@ -759,7 +759,7 @@ static int fc_target_match(struct attrib
 
 	i = to_fc_internal(shost->transportt);
 
-	return &i->t.host_attrs == cont;
+	return &i->t.target_attrs == cont;
 }
 
 
diff -puN a/drivers/scsi/scsi_transport_spi.c b/drivers/scsi/scsi_transport_spi.c
--- a/drivers/scsi/scsi_transport_spi.c	2005-02-02 14:58:01.000000000 -0500
+++ b/drivers/scsi/scsi_transport_spi.c	2005-02-02 15:32:52.000000000 -0500
@@ -148,7 +148,7 @@ static int spi_host_match(struct attribu
 
 	i = to_spi_internal(shost->transportt);
 
-	return &i->t.target_attrs == cont;
+	return &i->t.host_attrs == cont;
 }
 
 static int spi_device_configure(struct device *dev)
diff -puN a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
--- a/drivers/scsi/scsi_transport_iscsi.c	2005-02-02 15:30:56.000000000 -0500
+++ b/drivers/scsi/scsi_transport_iscsi.c	2005-02-02 15:32:07.000000000 -0500
@@ -289,7 +289,7 @@ static int iscsi_target_match(struct att
 
 	i = to_iscsi_internal(shost->transportt);
 
-	return &i->t.host_attrs == cont;
+	return &i->t.target_attrs == cont;
 }
 
 struct scsi_transport_template *
_

Re: [PATCH] fix the fix for multiple HBA problem with transport classes

[James Bottomley]

On Wed, 2005-02-02 at 15:55 -0500, James.Smart@Emulex.Com wrote:
> Testing was showing transport devices not being enumerated.
> 
> The reason was the wrong attribute container was being compared
> against in the "match" functions.  This patch fixes it.

OK, I confess ... I quietly fixed these three before sending the patch
to Linus.

James