From: Andrew Vasquez <andrew.vasquez@qlogic.com>
To: Linux SCSI Mailing List <linux-scsi@vger.kernel.org>,
James Bottomley <james.bottomley@steeleye.com>
Cc: Andrew Vasquez <andrew.vasquez@qlogic.com>,
Seokmann Ju <seokmann.ju@qlogic.com>
Subject: [PATCH 1/6] qla2xxx: fix RSCN handling on big-endian systems
Date: Mon, 12 Mar 2007 10:41:26 -0700 [thread overview]
Message-ID: <11737212912300-git-send-email-andrew.vasquez@qlogic.com> (raw)
In-Reply-To: <20070312174019.GA1216@andrew-vasquezs-computer.local>
From: malahal@us.ibm.com <malahal@us.ibm.com>
qla2xxx driver fails to handle RSCN events affecting area or domain due
to an endian issue on big endian systems. This fixes the port_id_t
structure on big endian systems.
Signed-off-by: Malahal Naineni <malahal@us.ibm.com>
Acked-by: Seokmann Ju <seokmann.ju@qlogic.com>
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
---
drivers/scsi/qla2xxx/qla_def.h | 13 ++++++++-----
1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
index 05f4f2a..e8948b6 100644
--- a/drivers/scsi/qla2xxx/qla_def.h
+++ b/drivers/scsi/qla2xxx/qla_def.h
@@ -1478,14 +1478,17 @@ typedef union {
uint32_t b24 : 24;
struct {
- uint8_t d_id[3];
- uint8_t rsvd_1;
- } r;
-
- struct {
+#ifdef __BIG_ENDIAN
+ uint8_t domain;
+ uint8_t area;
+ uint8_t al_pa;
+#elif __LITTLE_ENDIAN
uint8_t al_pa;
uint8_t area;
uint8_t domain;
+#else
+#error "__BIG_ENDIAN or __LITTLE_ENDIAN must be defined!"
+#endif
uint8_t rsvd_1;
} b;
} port_id_t;
--
1.5.0.3.382.g34572
next prev parent reply other threads:[~2007-03-12 17:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 17:40 [PATCH 0/6] qla2xxx: fixes for 2.6.21 [8.01.07-k6] Andrew Vasquez
2007-03-12 17:41 ` Andrew Vasquez [this message]
2007-03-12 17:41 ` [PATCH 2/6] qla2xxx: Add scan_[start|finish]() callbacks for ISP24xx HBAs Andrew Vasquez
2007-03-12 17:41 ` [PATCH 3/6] qla2xxx: Add cond_resched() calls during HBA flash manipulation Andrew Vasquez
2007-03-12 17:41 ` [PATCH 4/6] qla2xxx: Drop acquisition of hardware_lock during flash manipulations Andrew Vasquez
2007-03-12 17:41 ` [PATCH 5/6] qla2xxx: Allow the extended-error-logging flag to be dynamic Andrew Vasquez
2007-03-12 17:41 ` [PATCH 6/6] qla2xxx: Update version number to 8.01.07-k6 Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11737212912300-git-send-email-andrew.vasquez@qlogic.com \
--to=andrew.vasquez@qlogic.com \
--cc=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=seokmann.ju@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox