From: James Bottomley <James.Bottomley@SteelEye.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jens Axboe <jens.axboe@oracle.com>,
linux-scsi@vger.kernel.org, akpm@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: Fix old SCSI adapter crashes with CD-ROM (take 2)
Date: Tue, 08 May 2007 12:47:06 -0500 [thread overview]
Message-ID: <1178646426.3737.59.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <20070508184256.029cf8a4@the-village.bc.nu>
On Tue, 2007-05-08 at 18:42 +0100, Alan Cox wrote:
> > Mike Christie tells me we're missing bouncing by accident in the
> > scsi_execute path (but not the scsi_execute_async path). He says this
> > is the fix he proposed:
> >
> > http://marc.info/?l=linux-scsi&m=115981479822790&w=2
> >
> > Can we just merge this instead?
>
> Short answer: No
>
> Long answer - it doesn't take this path.
>
> Different bug, both want fixing I suspect.
Actually, it does take this path ... one of the things we've been doing
in SCSI is slowly eliminating the old direct submission paths in favour
of sending everything through the correct block layer paths.
scsi_execute(), which the sr ioctl uses is just such a fixed path ...
the bug is that it should be bouncing the request but because of an
oversight (which Mike's patch corrects) it doesn't.
The ultimate goal is to be able to eliminate the unchecked_isa_dma flag
entirely and have the block layer (or device mask allocations) fix all
of this in every ULD.
James
next prev parent reply other threads:[~2007-05-08 17:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 16:17 [PATCH]: Fix old SCSI adapter crashes with CD-ROM (take 2) Alan Cox
2007-05-08 16:14 ` Jens Axboe
2007-05-08 16:39 ` James Bottomley
2007-05-08 16:40 ` Jens Axboe
2007-05-08 16:52 ` James Bottomley
2007-05-08 17:15 ` Jens Axboe
2007-05-08 16:46 ` Mike Christie
2007-05-08 16:52 ` Jens Axboe
2007-05-08 17:42 ` Alan Cox
2007-05-08 17:47 ` James Bottomley [this message]
2007-05-08 17:53 ` Alan Cox
2007-05-08 17:58 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178646426.3737.59.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox