public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* Re: new runtime scsi warnings in 2.6.24-rc6+git
       [not found] <Pine.SOC.4.64.0801041231320.15055@math.ut.ee>
@ 2008-01-12 19:58 ` Rafael J. Wysocki
  2008-01-12 20:16   ` James Bottomley
  0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2008-01-12 19:58 UTC (permalink / raw)
  To: Meelis Roos; +Cc: Linux Kernel list, linux-scsi

On Friday, 4 of January 2008, Meelis Roos wrote:
> Todays git gives the following warning during bootup on a Intel 845+PATA 
> PC (using libata to drive PATA):
> 
> Driver 'sd' needs updating - please use bus_type methods
> Driver 'sr' needs updating - please use bus_type methods

They are due to commit 751bf4d7865e4ced406be93b04c7436d866d3684, AFAICS, and
they don't mean anything wrong.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: new runtime scsi warnings in 2.6.24-rc6+git
  2008-01-12 19:58 ` new runtime scsi warnings in 2.6.24-rc6+git Rafael J. Wysocki
@ 2008-01-12 20:16   ` James Bottomley
  0 siblings, 0 replies; 2+ messages in thread
From: James Bottomley @ 2008-01-12 20:16 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Meelis Roos, Linux Kernel list, linux-scsi, Greg KH, Kay Sievers


On Sat, 2008-01-12 at 20:58 +0100, Rafael J. Wysocki wrote:
> On Friday, 4 of January 2008, Meelis Roos wrote:
> > Todays git gives the following warning during bootup on a Intel 845+PATA 
> > PC (using libata to drive PATA):
> > 
> > Driver 'sd' needs updating - please use bus_type methods
> > Driver 'sr' needs updating - please use bus_type methods
> 
> They are due to commit 751bf4d7865e4ced406be93b04c7436d866d3684, AFAICS, and
> they don't mean anything wrong.

Yes ... SCSI actually is actually using the bus_type methods.  The issue
is that we need to cascade the removes so we're using the driver remove
method for this.  The warning appears if you have both a bus_type remove
and a driver remove (and a host of other duplicate methods), I think
because if the bus_type method is set, the driver method won't be
called.

However, we've taken all this into account and our bus type remove calls
into the driver remove itself ... unfortunately there seems to be no way
to persuade the driver core we know what we're doing.

James



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-01-12 20:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <Pine.SOC.4.64.0801041231320.15055@math.ut.ee>
2008-01-12 19:58 ` new runtime scsi warnings in 2.6.24-rc6+git Rafael J. Wysocki
2008-01-12 20:16   ` James Bottomley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox