[SCSI] scsi.h: add macro for enclosure bit of inquiry data

[SCSI] scsi.h: add macro for enclosure bit of inquiry data

[James Bottomley]

The macro tells us whether the device is (or contains) an enclosure device.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
---
 include/scsi/scsi_device.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index e0c645a..a262d11 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -386,6 +386,10 @@ static inline int scsi_device_qas(struct scsi_device *sdev)
 		return 0;
 	return sdev->inquiry[56] & 0x02;
 }
+static inline int scsi_device_enclosure(struct scsi_device *sdev)
+{
+	return sdev->inquiry[6] & (1<<6);
+}
 
 #define MODULE_ALIAS_SCSI_DEVICE(type) \
 	MODULE_ALIAS("scsi:t-" __stringify(type) "*")
-- 
1.5.3.8

Re: [SCSI] scsi.h: add macro for enclosure bit of inquiry data

[Stefan Richter]

James Bottomley wrote:
> The macro tells us whether the device is (or contains) an enclosure device.
...
> +static inline int scsi_device_enclosure(struct scsi_device *sdev)
> +{
> +	return sdev->inquiry[6] & (1<<6);
> +}

Perhaps call it scsi_device_is_enclosure() to better reflect the nature
of this function.

Or if it is an accessor to inquiry data to you, maybe call it
scsi_device_inquiry_encserv() or
scsi_device_inquiry_enclosure_services() or
sdev_to_inquiry_encserv() or
sdev_to_inquiry_enclosure_services().

Alas neither of this fits with the existing similar functions in
scsi_device.h which don't have expressive names.
-- 
Stefan Richter
-=====-==--- ---= =-=--
http://arcgraph.de/sr/

Re: [SCSI] scsi.h: add macro for enclosure bit of inquiry data

[James Bottomley]

On Sun, 2008-01-20 at 18:44 +0100, Stefan Richter wrote:
> James Bottomley wrote:
> > The macro tells us whether the device is (or contains) an enclosure device.
> ...
> > +static inline int scsi_device_enclosure(struct scsi_device *sdev)
> > +{
> > +	return sdev->inquiry[6] & (1<<6);
> > +}
> 
> Perhaps call it scsi_device_is_enclosure() to better reflect the nature
> of this function.
> 
> Or if it is an accessor to inquiry data to you, maybe call it
> scsi_device_inquiry_encserv() or
> scsi_device_inquiry_enclosure_services() or
> sdev_to_inquiry_encserv() or
> sdev_to_inquiry_enclosure_services().
> 
> Alas neither of this fits with the existing similar functions in
> scsi_device.h which don't have expressive names.

Right .. that's the problem.  Being potentially clearer in naming but at
odds with what's currently in the file starts to add to the confusion
about the other names in there.  I chose the name primarily because it's
the same form as all the others.

James