From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net, linux-scsi@vger.kernel.org
Subject: Re: on patch "[SCSI] relax scsi dma alignment"
Date: Sat, 26 Jan 2008 12:54:02 -0600 [thread overview]
Message-ID: <1201373642.4387.0.camel@localhost.localdomain> (raw)
In-Reply-To: <479B80A3.5070207@s5r6.in-berlin.de>
On Sat, 2008-01-26 at 19:49 +0100, Stefan Richter wrote:
> On commit 465ff3185e0cb76d46137335a4d21d0d9d3ac8a2:
> > This patch relaxes the default SCSI DMA alignment from 512 bytes to 4
> > bytes. I remember from previous discussions that usb and firewire have
> > sector size alignment requirements, so I upped their alignments in the
> > respective slave allocs.
> [...]
> > drivers/ata/libata-scsi.c | 5 ++++-
> > drivers/firewire/fw-sbp2.c | 6 ++++++
> > drivers/ieee1394/sbp2.c | 6 ++++++
> > drivers/scsi/scsi_lib.c | 8 ++++++++
> > drivers/usb/storage/scsiglue.c | 20 ++++++++++----------
> > 5 files changed, 34 insertions(+), 11 deletions(-)
>
> No, FireWire only requires 4 bytes alignment.
>
> I will channel a reversion of the firewire and ieee1394 hunks through
> linux1394-2.6.git for 2.6.26.
Don't revert, just put the numbers down to 4 (just in case someone
decides to lower the default SCSI alignment down from four ...).
James
next prev parent reply other threads:[~2008-01-26 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-26 18:49 on patch "[SCSI] relax scsi dma alignment" Stefan Richter
2008-01-26 18:54 ` James Bottomley [this message]
2008-01-27 21:31 ` [PATCH 2.6.24-git3] firewire: fw-sbp2: relax SCSI DMA alignment Stefan Richter
2008-01-27 21:32 ` [PATCH 2.6.24-git3] ieee1394: sbp2: " Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201373642.4387.0.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox