public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: [PATCH 2.6.24-git3] firewire: fw-sbp2: relax SCSI DMA alignment
Date: Sun, 27 Jan 2008 22:31:27 +0100 (CET)	[thread overview]
Message-ID: <tkrat.6b01fb9bb536c584@s5r6.in-berlin.de> (raw)
In-Reply-To: <1201373642.4387.0.camel@localhost.localdomain>

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---

Not run-time tested yet.

 drivers/firewire/fw-sbp2.c |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Index: linux-2.6.24-git3/drivers/firewire/fw-sbp2.c
===================================================================
--- linux-2.6.24-git3.orig/drivers/firewire/fw-sbp2.c
+++ linux-2.6.24-git3/drivers/firewire/fw-sbp2.c
@@ -1309,11 +1309,8 @@ static int sbp2_scsi_slave_alloc(struct 
 
 	sdev->allow_restart = 1;
 
-	/*
-	 * Update the dma alignment (minimum alignment requirements for
-	 * start and end of DMA transfers) to be a sector
-	 */
-	blk_queue_update_dma_alignment(sdev->request_queue, 511);
+	/* SBP-2 requires quadlet alignment of the data buffers. */
+	blk_queue_update_dma_alignment(sdev->request_queue, 4 - 1);
 
 	if (lu->tgt->workarounds & SBP2_WORKAROUND_INQUIRY_36)
 		sdev->inquiry_len = 36;

-- 
Stefan Richter
-=====-==--- ---= ==-==
http://arcgraph.de/sr/


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  reply	other threads:[~2008-01-27 21:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-26 18:49 on patch "[SCSI] relax scsi dma alignment" Stefan Richter
2008-01-26 18:54 ` James Bottomley
2008-01-27 21:31   ` Stefan Richter [this message]
2008-01-27 21:32     ` [PATCH 2.6.24-git3] ieee1394: sbp2: relax SCSI DMA alignment Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tkrat.6b01fb9bb536c584@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox