Re: [PATCH 1/1] aacraid: pci_set_dma_max_seg_size opened up for late model controllers

[James Bottomley <James.Bottomley@HansenPartnership.com>]

On Wed, 2008-02-06 at 09:00 -0800, Salyzyn, Mark wrote:
> This patch depends on 'RE: [patch 048/265] iommu sg merging: aacraid: use pci_set_dma_max_seg_size' and ensures that the modern adapters get a maximum sg segment size on par with the maximum transfer size. Added some localized janitor fixes to the discussion patch I used with Fujita.
> 
> FUJITA Tomonori [mailto:fujita.tomonori@lab.ntt.co.jp] sez:
> > I think that setting the proper maximum segment size for the late
> > model cards (as you did above) makes sense.
> 
> This attached patch is against current linux-2.6. It will not apply to current scsi-misc-2.6 without the above mentioned dependency.
> 
> ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch attachments. Please use the attached file to patch
> 
> Signed-off-by: Mark Salyzyn <aacraid@adaptec.com>

OK, I have this, but someone really needs to do a little more checkpatch
love:

jejb@mulgrave> ./scripts/checkpatch.pl ~/tmp.mail
ERROR: use tabs not spaces
#44: FILE: drivers/scsi/aacraid/linit.c:1138:
+ ^I^Ishost->sg_tablesize = 34;$

ERROR: use tabs not spaces
#45: FILE: drivers/scsi/aacraid/linit.c:1139:
+ ^I^Ishost->max_sectors = (shost->sg_tablesize * 8) + 112;$

ERROR: use tabs not spaces
#54: FILE: drivers/scsi/aacraid/linit.c:1144:
+ ^I^Ishost->sg_tablesize = 17;$

ERROR: use tabs not spaces
#55: FILE: drivers/scsi/aacraid/linit.c:1145:
+ ^I^Ishost->max_sectors = (shost->sg_tablesize * 8) + 112;$

ERROR: use tabs not spaces
#60: FILE: drivers/scsi/aacraid/linit.c:1150:
+ ^I^I^I(shost->max_sectors << 9) : 65536);$

total: 5 errors, 0 warnings, 44 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

James