From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Salyzyn, Mark" <Mark_Salyzyn@adaptec.com>
Cc: "'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/1] aacraid: add optional MSI support.
Date: Thu, 07 Feb 2008 18:30:34 -0600 [thread overview]
Message-ID: <1202430634.3171.41.camel@localhost.localdomain> (raw)
In-Reply-To: <532ABFBDAAC3A34EB12EBA6CEC2838F43982A010@ADPE2K703.adaptec.com>
On Wed, 2008-02-06 at 13:20 -0800, Salyzyn, Mark wrote:
> Added support for MSI utilizing the aacraid.msi=1 parameter. This patch adds some localized or like-minded janitor fixes. Since the default is disabled, there is no impact on the code paths unless the customer wishes to experiment with the MSI performance.
>
> This patch is against current scsi-misc-2.6
It doesn't seem to compile:
drivers/scsi/aacraid/sa.c: In function 'aac_sa_init':
drivers/scsi/aacraid/sa.c:388: error: dereferencing pointer to incomplete type
drivers/scsi/aacraid/sa.c:406: error: dereferencing pointer to incomplete type
It looks like this can be corrected by #include <linux/pci.h> since it's
struct pci_dev that's the incomplete type.
James
next prev parent reply other threads:[~2008-02-08 0:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <532ABFBDAAC3A34EB12EBA6CEC2838F4397D643D@ADPE2K703.adaptec.com>
[not found] ` <20080205234912B.tomof@acm.org>
[not found] ` <532ABFBDAAC3A34EB12EBA6CEC2838F4397D6932@ADPE2K703.adaptec.com>
[not found] ` <20080206101148L.fujita.tomonori@lab.ntt.co.jp>
2008-02-06 17:00 ` [PATCH 1/1] aacraid: pci_set_dma_max_seg_size opened up for late model controllers Salyzyn, Mark
2008-02-06 17:54 ` James Bottomley
2008-02-06 18:08 ` [PATCH 1/1] aacraid: pci_set_dma_max_seg_size opened up for late model controllers (take 2) Salyzyn, Mark
2008-02-06 21:20 ` [PATCH 1/1] aacraid: add optional MSI support Salyzyn, Mark
2008-02-08 0:30 ` James Bottomley [this message]
2008-02-08 13:48 ` [PATCH 1/1] aacraid: add optional MSI support (take 2) Salyzyn, Mark
2008-02-08 16:36 ` [PATCH 1/1] aacraid: ignore adapter reset check polarity Salyzyn, Mark
2008-02-08 17:01 ` [PATCH 1/1] aacraid: informational sysfs value corrections Salyzyn, Mark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202430634.3171.41.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=Mark_Salyzyn@adaptec.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox