Fix for problems introduced by enabling MSI by default for MPT SPI controllers

Fix for problems introduced by enabling MSI by default for MPT SPI controllers

[Prakash, Sathya]

Recently there are some issues posted in the list with regards to failure of booting or failure of driver loading  when the MSI is enabled by default for MPT SPI controllers.

James has already provided the patch for fixing the panic.

But the reason for IOC bring up failure is enabling the MSI by default for SPI controllers.  The issue is introduced by the following patch. Which is intended for enabling the MSI only for SAS controllers but enables MSI for SPI, FC and SAS controllers.
http://marc.info/?l=linux-scsi&m=120488594802569&w=4

I have already posted another patch to rectify this so that MSI will not be enabled by default for SPI and FC controllers. The link for the correction patch is as below.
http://marc.info/?l=linux-scsi&m=121131228827682&w=4

Thanks
Sathya

Re: Fix for problems introduced by enabling MSI by default for MPT SPI controllers

[James Bottomley]

On Wed, 2008-07-09 at 14:54 +0800, Prakash, Sathya wrote:
> Recently there are some issues posted in the list with regards to failure of booting or failure of driver loading  when the MSI is enabled by default for MPT SPI controllers.
> 
> James has already provided the patch for fixing the panic.
> 
> But the reason for IOC bring up failure is enabling the MSI by default for SPI controllers.  The issue is introduced by the following patch. Which is intended for enabling the MSI only for SAS controllers but enables MSI for SPI, FC and SAS controllers.
> http://marc.info/?l=linux-scsi&m=120488594802569&w=4
> 
> I have already posted another patch to rectify this so that MSI will not be enabled by default for SPI and FC controllers. The link for the correction patch is as below.
> http://marc.info/?l=linux-scsi&m=121131228827682&w=4

Is there an actual fault in the MSI controller on the SPI and FC fusion?
I'm asking because usually we just follow the platform defaults unless
there's a specific reason to blacklist the individual device.

James

RE: Fix for problems introduced by enabling MSI by default for MPT SPI controllers

[Prakash, Sathya]

We have some known cases of MSI not working with FC and SPI controllers, that is the reason we don't want to enable the MSI for them by default.
Thanks
Sathya

-----Original Message-----
From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of James Bottomley
Sent: Wednesday, July 09, 2008 7:41 PM
To: Prakash, Sathya
Cc: linux-scsi@vger.kernel.org; Moore, Eric
Subject: Re: Fix for problems introduced by enabling MSI by default for MPT SPI controllers

On Wed, 2008-07-09 at 14:54 +0800, Prakash, Sathya wrote:
> Recently there are some issues posted in the list with regards to failure of booting or failure of driver loading  when the MSI is enabled by default for MPT SPI controllers.
>
> James has already provided the patch for fixing the panic.
>
> But the reason for IOC bring up failure is enabling the MSI by default for SPI controllers.  The issue is introduced by the following patch. Which is intended for enabling the MSI only for SAS controllers but enables MSI for SPI, FC and SAS controllers.
> http://marc.info/?l=linux-scsi&m=120488594802569&w=4
>
> I have already posted another patch to rectify this so that MSI will not be enabled by default for SPI and FC controllers. The link for the correction patch is as below.
> http://marc.info/?l=linux-scsi&m=121131228827682&w=4

Is there an actual fault in the MSI controller on the SPI and FC fusion?
I'm asking because usually we just follow the platform defaults unless there's a specific reason to blacklist the individual device.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: Fix for problems introduced by enabling MSI by default for MPT SPI controllers

[James Bottomley]

On Thu, 2008-07-10 at 16:38 +0800, Prakash, Sathya wrote:
> We have some known cases of MSI not working with FC and SPI controllers, that is the reason we don't want to enable the MSI for them by default.

Is that because of motherboard problems or because of actual on board
issues with the fusion controller?

James