[PATCH] 2.6.27-rc2 SCSI Rewrite help text for SCSI_SAS_HOST_SMP

[PATCH] 2.6.27-rc2 SCSI Rewrite help text for SCSI_SAS_HOST_SMP

[Grant Grundler]

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]

Rewrite libsas/Kconfig help text for SCSI_SAS_HOST_SMP option.
Previous text is useless. Thanks for Martin Petersen (mkp) for pointing
me in the right direction.

Signed-off-By: Grant Grundler <grundler@google.com>

(sorry - patch attached instead of inline because, uhm, gmail white
space mangles patches. Yes, we've complained about it).

New text reads:
+               Allows SAS hosts to receive SAS Management Protocol (SMP)
+               frames.  Selecting this option builds an SMP interpreter
+               into libsas. SMP frames are used to manage SAS expanders
+               and routing of SAS frames.
+
+               For more details see:
+                       http://www.scsita.org/aboutscsi/sas/tutorials.html
+                       http://www.t11.org/ftp/t11/pub/sm/hba/04-373v0.pdf
+
+               Say N here if you want to save the few kb this consumes.

[-- Attachment #2: diff-2.6.27-rc2-libsas_kconfig-01 --]
[-- Type: application/octet-stream, Size: 939 bytes --]

diff --git a/drivers/scsi/libsas/Kconfig b/drivers/scsi/libsas/Kconfig
index 18f33cd..06fb3ea 100644
--- a/drivers/scsi/libsas/Kconfig
+++ b/drivers/scsi/libsas/Kconfig
@@ -43,9 +43,16 @@ config SCSI_SAS_HOST_SMP
 	default y
 	depends on SCSI_SAS_LIBSAS
 	help
-		Allows sas hosts to receive SMP frames.  Selecting this
-		option builds an SMP interpreter into libsas.  Say
-		N here if you want to save the few kb this consumes.
+		Allows SAS hosts to receive SAS Management Protocol (SMP)
+		frames.  Selecting this option builds an SMP interpreter
+		into libsas. SMP frames are used to manage SAS expanders
+		and routing of SAS frames.
+
+		For more details see:
+			http://www.scsita.org/aboutscsi/sas/tutorials.html
+			http://www.t11.org/ftp/t11/pub/sm/hba/04-373v0.pdf
+
+		Say N here if you want to save the few kb this consumes.
 
 config SCSI_SAS_LIBSAS_DEBUG
 	bool "Compile the SAS Domain Transport Attributes in debug mode"

Re: [PATCH] 2.6.27-rc2 SCSI Rewrite help text for SCSI_SAS_HOST_SMP

[James Bottomley]

On Tue, 2008-08-12 at 14:35 -0700, Grant Grundler wrote:
> Rewrite libsas/Kconfig help text for SCSI_SAS_HOST_SMP option.
> Previous text is useless. Thanks for Martin Petersen (mkp) for pointing
> me in the right direction.
> 
> Signed-off-By: Grant Grundler <grundler@google.com>
> 
> (sorry - patch attached instead of inline because, uhm, gmail white
> space mangles patches. Yes, we've complained about it).
> 
> New text reads:
> +               Allows SAS hosts to receive SAS Management Protocol (SMP)
> +               frames.  Selecting this option builds an SMP interpreter
> +               into libsas. SMP frames are used to manage SAS expanders
> +               and routing of SAS frames.

Actually, you're making it less clear.

What this option is doing is allowing the smp utilities to send SMP
frames to interrogate the HBA.  Setting (or not setting) this option has
no effect on the SAS expanders.  Essentially, it allows the HBA ports to
be treated the same as the expander ports from the point of view of a
software management tool.

> +               For more details see:
> +                       http://www.scsita.org/aboutscsi/sas/tutorials.html

It's not the whole of this, just the Management upper layer.

> +                       http://www.t11.org/ftp/t11/pub/sm/hba/04-373v0.pdf

This latter one is the HBA API ... it's not really anything to do with
SMP.

James

Re: [PATCH] 2.6.27-rc2 SCSI Rewrite help text for SCSI_SAS_HOST_SMP

[Grant Grundler]

[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]

On Tue, Aug 12, 2008 at 2:46 PM, James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
...
> Actually, you're making it less clear.

Sorry - I've rewritten it to reflect your take on it.

>
> What this option is doing is allowing the smp utilities to send SMP
> frames to interrogate the HBA.  Setting (or not setting) this option has
> no effect on the SAS expanders.  Essentially, it allows the HBA ports to
> be treated the same as the expander ports from the point of view of a
> software management tool.

Word smithed so it N=now reads:
+               Selecting this option builds an SMP interpreter into libsas.
+               This allows SAS Management Protocol (SMP) utilities to send
+               SMP frames to interrogate the HBA. Essentially, this allows
+               SMP utilities to treat HBA ports the same as SAS Expander
+               Ports.
+
+               For more details on the Management Upper Layer see:
+                       http://www.scsita.org/aboutscsi/sas/tutorials.html
+
+               Say N here if you want to save the few kb this consumes.

Attached as a patch file again but I can re-send in proper format if you prefer.

>
>> +               For more details see:
>> +                       http://www.scsita.org/aboutscsi/sas/tutorials.html
>
> It's not the whole of this, just the Management upper layer.
>
>> +                       http://www.t11.org/ftp/t11/pub/sm/hba/04-373v0.pdf
>
> This latter one is the HBA API ... it's not really anything to do with
> SMP.

*nod* dropped the second URL.

thanks,
grant

[-- Attachment #2: diff-2.6.27-rc2-libsas_kconfig-02 --]
[-- Type: application/octet-stream, Size: 863 bytes --]

--- a/drivers/scsi/libsas/Kconfig
+++ b/drivers/scsi/libsas/Kconfig
@@ -43,9 +43,16 @@ config SCSI_SAS_HOST_SMP
 	default y
 	depends on SCSI_SAS_LIBSAS
 	help
-		Allows sas hosts to receive SMP frames.  Selecting this
-		option builds an SMP interpreter into libsas.  Say
-		N here if you want to save the few kb this consumes.
+		Selecting this option builds an SMP interpreter into libsas.
+		This allows SAS Management Protocol (SMP) utilities to send
+		SMP frames to interrogate the HBA. Essentially, this allows
+		SMP utilities to treat HBA ports the same as SAS Expander
+		Ports.
+
+		For more details on the Management Upper Layer see:
+			http://www.scsita.org/aboutscsi/sas/tutorials.html
+
+		Say N here if you want to save the few kb this consumes.
 
 config SCSI_SAS_LIBSAS_DEBUG
 	bool "Compile the SAS Domain Transport Attributes in debug mode"