Re: PATCH: mvsas: increase port type detection delay to suit Seagate's 15k6 drive ST3450856SS 0003

Re: PATCH: mvsas: increase port type detection delay to suit Seagate's 15k6 drive ST3450856SS 0003

[Reinhard Nissl]

[-- Attachment #1: Type: text/plain, Size: 744 bytes --]

Hi,

I wonder why no one has dropped me a line so far. I hope you
don't mind CCing you directly. I found your email addresses on
mailing list entries regarding mvsas. I attach the little patch
again for ease of use.

Reinhard Nissl schrieb:

> I increased the delay step by step until loading of mvsas
> reliably detected the drive 200 times in sequence. A much better
> approach would be to monitor the hardware for some flag which
> indicates that port detection has finished, but I do not have any
> hardware documentation.
> 
> BTW: patch is against
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.27.y.git
> 
> Signed-off-by: Reinhard Nissl <rnissl@gmx.de>

Bye.
-- 
Dipl.-Inform. (FH) Reinhard Nissl
mailto:rnissl@gmx.de

[-- Attachment #2: mvsas.diff --]
[-- Type: text/x-patch, Size: 450 bytes --]

diff --git a/drivers/scsi/mvsas.c b/drivers/scsi/mvsas.c
index 1dd70d7..23e5a87 100644
--- a/drivers/scsi/mvsas.c
+++ b/drivers/scsi/mvsas.c
@@ -2959,7 +2959,7 @@ static int __devinit mvs_hw_init(struct mvs_info *mvi)
 
 	/* enable auto port detection */
 	mw32(GBL_PORT_TYPE, MODE_AUTO_DET_EN);
-	msleep(100);
+	msleep(1100);
 	/* init and reset phys */
 	for (i = 0; i < mvi->chip->n_phy; i++) {
 		u32 lo = be32_to_cpu(*(u32 *)&mvi->sas_addr[4]);

PATCH: mvsas: increase port type detection delay to suit Seagate's 15k6 drive ST3450856SS 0003

[Roland]

as this driver is relatively new, is it already stable enough for production 
use ?

i thought about buying a mobo with marvell sas controller.

is it planned to merge this patch, as it is fixing a problem or must this 
problems being workarounded in userspace ?

here`s some more with that problem:

https://bugzilla.redhat.com/show_bug.cgi?id=474482
http://forumubuntusoftware.info/viewtopic.php?f=46&t=2454

regards
roland


List:       linux-scsi
Subject:    PATCH: mvsas: increase port type detection delay to suit 
Seagate's 15k6 drive ST3450856SS 0003
From:       Reinhard Nissl <rnissl () gmx ! de>
Date:       2008-12-10 23:31:03
Message-ID: 49405137.9000902 () gmx ! de
[Download message RAW]

I increased the delay step by step until loading of mvsas
reliably detected the drive 200 times in sequence. A much better
approach would be to monitor the hardware for some flag which
indicates that port detection has finished, but I do not have any
hardware documentation.

BTW: patch is against
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.27.y.git

Signed-off-by: Reinhard Nissl <rnissl@gmx.de>


["mvsas.diff" (text/x-patch)]

diff --git a/drivers/scsi/mvsas.c b/drivers/scsi/mvsas.c
index 1dd70d7..23e5a87 100644
--- a/drivers/scsi/mvsas.c
+++ b/drivers/scsi/mvsas.c
@@ -2959,7 +2959,7 @@ static int __devinit mvs_hw_init(struct mvs_info *mvi)

  /* enable auto port detection */
  mw32(GBL_PORT_TYPE, MODE_AUTO_DET_EN);
- msleep(100);
+ msleep(1100);
  /* init and reset phys */
  for (i = 0; i < mvi->chip->n_phy; i++) {
   u32 lo = be32_to_cpu(*(u32 *)&mvi->sas_addr[4]); 

Re: PATCH: mvsas: increase port type detection delay to suit Seagate's 15k6 drive ST3450856SS 0003

[James Bottomley]

On Tue, 2008-12-30 at 02:08 +0100, Roland wrote:
> as this driver is relatively new, is it already stable enough for production 
> use ?

It passes my testing, including some nicely error prone expander
configurations ... however, I assume you'll put it through its
qualification paces.

> i thought about buying a mobo with marvell sas controller.
> 
> is it planned to merge this patch, as it is fixing a problem or must this 
> problems being workarounded in userspace ?

Ideally, I'd like marvell to comment on this since just increasing the
timer looks like it's hiding some type of race in the driver ...
however, since it's been around for nearly a month now with no response
and it looks relatively harmless, I'll put it in.

> here`s some more with that problem:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=474482
> http://forumubuntusoftware.info/viewtopic.php?f=46&t=2454

James