From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: torvalds@linux-foundation.org, linux-scsi@vger.kernel.org,
jaswinder@infradead.org
Subject: Re: [PATCH] qlogicpti: use request_firmware
Date: Sat, 10 Jan 2009 09:58:17 -0600 [thread overview]
Message-ID: <1231603097.3642.25.camel@localhost.localdomain> (raw)
In-Reply-To: <1231600926.5806.131.camel@macbook.infradead.org>
On Sat, 2009-01-10 at 15:22 +0000, David Woodhouse wrote:
> From: Jaswinder Singh <jaswinder@infradead.org>
>
> Firmware blob is little endian
>
> Thanks to Stephen Rothwell for fixing typos
>
> Signed-off-by: Jaswinder Singh <jaswinder@infradead.org>
> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
> ---
> drivers/scsi/qlogicpti.c | 63 ++-
> drivers/scsi/qlogicpti_asm.c | 1160 --------------------------------------
> firmware/Makefile | 1 +
> firmware/WHENCE | 10 +
> firmware/qlogic/isp1000.bin.ihex | 1158 +++++++++++++++++++++++++++++++++++++
> 5 files changed, 1210 insertions(+), 1182 deletions(-)
> delete mode 100644 drivers/scsi/qlogicpti_asm.c
> create mode 100644 firmware/qlogic/isp1000.bin.ihex
I'm assuming this fixes the open firmware conversion bug?
What about the missing Kconfig piece? FW_LOADER must be selected
otherwise you can build a config where the device can't possibly work.
James
next prev parent reply other threads:[~2009-01-10 15:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 15:22 [PATCH] qlogicpti: use request_firmware David Woodhouse
2009-01-10 15:58 ` James Bottomley [this message]
2009-01-10 19:19 ` David Woodhouse
2009-01-10 23:30 ` James Bottomley
2009-01-11 6:19 ` Jaswinder Singh Rajput
-- strict thread matches above, loose matches on Subject: below --
2008-07-20 8:59 Jaswinder Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231603097.3642.25.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=dwmw2@infradead.org \
--cc=jaswinder@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox