Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: torvalds@linux-foundation.org, linux-scsi@vger.kernel.org,
	jaswinder@infradead.org
Subject: Re: [PATCH] qlogicpti: use request_firmware
Date: Sat, 10 Jan 2009 17:30:39 -0600	[thread overview]
Message-ID: <1231630239.3642.56.camel@localhost.localdomain> (raw)
In-Reply-To: <1231615150.5806.137.camel@macbook.infradead.org>

On Sat, 2009-01-10 at 19:19 +0000, David Woodhouse wrote:
> On Sat, 2009-01-10 at 09:58 -0600, James Bottomley wrote:
> > I'm assuming this fixes the open firmware conversion bug?
> 
> Which bug was that?

This one:

Subject: 	linux-next: scsi tree build failure
Date: 	Wed, 31 Dec 2008 03:16:39 +1100 (Tue, 10:16 CST)


Hi James,

Today's linux-next build (sparc defconfig) failed like this:

drivers/scsi/qlogicpti.c: In function 'qlogicpti_load_firmware':
drivers/scsi/qlogicpti.c:480: error: 'struct qlogicpti' has no member
named 'sdev'

An interaction between commit 68175399c8b5ee90960e78c1bb8e3353e71fbf33
("[SCSI] qlogicpti: use request_firmware") from the scsi tree and commit
5dc2536bb8d8adb5fdfbe76cd6fdcdf9de3f40f8 ("qlogicpti: Convert to pure OF
driver") which is in Linus' tree.

The version of the firmware commit that has been in the firmware tree
since Nov 19 has this conflict corrected.

I have left it for today (as it is getting way to late).  Please fix it
up for tomorrow.


  reply	other threads:[~2009-01-10 23:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-10 15:22 [PATCH] qlogicpti: use request_firmware David Woodhouse
2009-01-10 15:58 ` James Bottomley
2009-01-10 19:19   ` David Woodhouse
2009-01-10 23:30     ` James Bottomley [this message]
2009-01-11  6:19       ` Jaswinder Singh Rajput
  -- strict thread matches above, loose matches on Subject: below --
2008-07-20  8:59 Jaswinder Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1231630239.3642.56.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=dwmw2@infradead.org \
    --cc=jaswinder@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox