From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Matthew Wilcox <matthew@wil.cx>,
linux-scsi@vger.kernel.org,
Brian King <brking@linux.vnet.ibm.com>
Subject: Re: [PATCH] Convert scsi_scan to use generic async mechanism
Date: Sat, 23 May 2009 12:07:05 -0500 [thread overview]
Message-ID: <1243098425.3630.26.camel@localhost.localdomain> (raw)
In-Reply-To: <20090523095108.6ccccd08@infradead.org>
On Sat, 2009-05-23 at 09:51 -0700, Arjan van de Ven wrote:
> On Sat, 23 May 2009 11:21:43 -0500
> > The reason scsi_add_device() is failing seems to be that
> > async_synchronize_full_domain() is a bit fragile in that it only
> > expects to be called once. Call it again, like we do, to make sure
> > there aren't any outstanding scans and it hangs on the wait event.
>
> it's supposed to be ok to call as many times as you want.
> What is NOT allowed is calling it from async work itself, due to the
> obvious deadlock.
The call trace doesn't seem to show we're nested ... although I suppose
we could eventually be if someone decided to do async PCI scanning.
Any other thoughts as to why this would be hanging?
James
next prev parent reply other threads:[~2009-05-23 17:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 19:35 [PATCH] Convert scsi_scan to use generic async mechanism Matthew Wilcox
2009-04-29 14:39 ` Matthew Wilcox
2009-05-23 16:21 ` James Bottomley
2009-05-23 16:51 ` Arjan van de Ven
2009-05-23 17:07 ` James Bottomley [this message]
2009-05-23 20:42 ` James Bottomley
2009-05-23 20:39 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243098425.3630.26.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=arjan@infradead.org \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox