From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-scsi@vger.kernel.org, Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] Convert scsi_scan to use generic async mechanism
Date: Sat, 23 May 2009 15:39:19 -0500 [thread overview]
Message-ID: <1243111159.3630.36.camel@localhost.localdomain> (raw)
In-Reply-To: <20090428193557.GC21648@parisc-linux.org>
On Tue, 2009-04-28 at 13:35 -0600, Matthew Wilcox wrote:
> + scsi_host_get(shost);
> + cookie = async_schedule_domain(async_scsi_scan_host, shost,
> + &scan_domain);
> + if (strncmp(scsi_scan_type, "sync", 4) == 0)
> + async_synchronize_cookie_domain(cookie, &scan_domain);
This last statement doesn't actually do anything. It waits for all
prior scans to complete, but not this one, so we're not actually
synchronous here ... we don't wait for the scan we just kicked off to
complete.
Arjan suggests a way to hack around this might be
async_synchronize_cookie_domain(cookie + 1, &scan_domain);
James
prev parent reply other threads:[~2009-05-23 20:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 19:35 [PATCH] Convert scsi_scan to use generic async mechanism Matthew Wilcox
2009-04-29 14:39 ` Matthew Wilcox
2009-05-23 16:21 ` James Bottomley
2009-05-23 16:51 ` Arjan van de Ven
2009-05-23 17:07 ` James Bottomley
2009-05-23 20:42 ` James Bottomley
2009-05-23 20:39 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243111159.3630.36.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=arjan@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox