public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fnic: use DMA_BIT_MASK(nn) instead of deprecated DMA_nnBIT_MASK
@ 2009-06-24 14:42 Abhijeet Joglekar
  2009-06-24 22:02 ` Robert Love
  0 siblings, 1 reply; 2+ messages in thread
From: Abhijeet Joglekar @ 2009-06-24 14:42 UTC (permalink / raw)
  To: linux-scsi; +Cc: abjoglek, robert.w.love, jeykholt

Robert Love reported warning while building fnic_main.c:
drivers/scsi/fnic/fnic_main.c:478: warning: `DMA_nnBIT_MASK' is deprecated.

Replaced use of DMA_nnBIT_MASK by DMA_BIT_MASK(nn)

Signed-off-by: Abhijeet Joglekar <abjoglek@cisco.com>
---
 drivers/scsi/fnic/fnic_main.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)


diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c
index a840728..2c266c0 100644
--- a/drivers/scsi/fnic/fnic_main.c
+++ b/drivers/scsi/fnic/fnic_main.c
@@ -473,16 +473,16 @@ static int __devinit fnic_probe(struct pci_dev *pdev,
 	 * limitation for the device.  Try 40-bit first, and
 	 * fail to 32-bit.
 	 */
-	err = pci_set_dma_mask(pdev, DMA_40BIT_MASK);
+	err = pci_set_dma_mask(pdev, DMA_BIT_MASK(40));
 	if (err) {
-		err = pci_set_dma_mask(pdev, DMA_32BIT_MASK);
+		err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
 		if (err) {
 			shost_printk(KERN_ERR, fnic->lport->host,
 				     "No usable DMA configuration "
 				     "aborting\n");
 			goto err_out_release_regions;
 		}
-		err = pci_set_consistent_dma_mask(pdev, DMA_32BIT_MASK);
+		err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
 		if (err) {
 			shost_printk(KERN_ERR, fnic->lport->host,
 				     "Unable to obtain 32-bit DMA "
@@ -490,7 +490,7 @@ static int __devinit fnic_probe(struct pci_dev *pdev,
 			goto err_out_release_regions;
 		}
 	} else {
-		err = pci_set_consistent_dma_mask(pdev, DMA_40BIT_MASK);
+		err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(40));
 		if (err) {
 			shost_printk(KERN_ERR, fnic->lport->host,
 				     "Unable to obtain 40-bit DMA "



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fnic: use DMA_BIT_MASK(nn) instead of deprecated DMA_nnBIT_MASK
  2009-06-24 14:42 [PATCH] fnic: use DMA_BIT_MASK(nn) instead of deprecated DMA_nnBIT_MASK Abhijeet Joglekar
@ 2009-06-24 22:02 ` Robert Love
  0 siblings, 0 replies; 2+ messages in thread
From: Robert Love @ 2009-06-24 22:02 UTC (permalink / raw)
  To: Abhijeet Joglekar; +Cc: linux-scsi@vger.kernel.org, jeykholt@cisco.com

On Wed, 2009-06-24 at 07:42 -0700, Abhijeet Joglekar wrote:
> Robert Love reported warning while building fnic_main.c:
> drivers/scsi/fnic/fnic_main.c:478: warning: `DMA_nnBIT_MASK' is deprecated.
> 
> Replaced use of DMA_nnBIT_MASK by DMA_BIT_MASK(nn)
> 
This resolves the warning that I was seeing.

> Signed-off-by: Abhijeet Joglekar <abjoglek@cisco.com>

This may be too trivial for something like this, but anyway-

Tested-by: Robert Love <robert.w.love@intel.com>



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-06-24 22:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-24 14:42 [PATCH] fnic: use DMA_BIT_MASK(nn) instead of deprecated DMA_nnBIT_MASK Abhijeet Joglekar
2009-06-24 22:02 ` Robert Love

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox