Re: [PATCH 1/7] mpt2sas : Rescan topology from Interrupt context instead of work queue

Re: [PATCH 1/7] mpt2sas : Rescan topology from Interrupt context instead of work queue

[James Bottomley]

On Fri, 2009-08-14 at 15:13 +0530, Kashyap, Desai wrote:
> Following host reset its possible that the controller firmware could
> assign new handles for devices, as well as adding or deleting devices. There is
> code in the driver that will rescan the topology folowing host reset; updating
> device handles, and remove devices that are no longer responding. This patch
> will improve the responsivness by moving this rescaning from the delayed hotplug
> worker thread to immediately following the host reset.
> 
> ---
> 
> Signed-off-by: Kashyap Desai <kashyap.desai@lsi.com>
> Signed-off-by: Eric Moore <Eric.moore@lsi.com>

For the third time of asking, can you put the signoffs *before* the
three dashes that tell the git importer to ignore the rest of the text
before the patch?

Also, what exactly do these signoffs mean ... they're supposed to track
author and whose hands these patches have been through.  If Eric wrote
them, and you're just submitting them, I need a From: field at the
beginning to change the git authorship (and also the order of signoff
needs reversing).

James

RE: [PATCH 1/7] mpt2sas : Rescan topology from Interrupt context instead of work queue

[Moore, Eric]

On Friday, August 14, 2009 9:00 AM,  James Bottomley wrote:

> Also, what exactly do these signoffs mean ... they're 
> supposed to track
> author and whose hands these patches have been through.  If Eric wrote
> them, and you're just submitting them, I need a From: field at the
> beginning to change the git authorship (and also the order of signoff
> needs reversing).
> 

I worked the fix back in May.   Kashyap is generating the patch's, and I'm reviewing them.

Eric Moore

RE: [PATCH 1/7] mpt2sas : Rescan topology from Interrupt context instead of work queue

[James Bottomley]

On Fri, 2009-08-14 at 09:05 -0600, Moore, Eric wrote:
> On Friday, August 14, 2009 9:00 AM,  James Bottomley wrote:
> 
> > Also, what exactly do these signoffs mean ... they're 
> > supposed to track
> > author and whose hands these patches have been through.  If Eric wrote
> > them, and you're just submitting them, I need a From: field at the
> > beginning to change the git authorship (and also the order of signoff
> > needs reversing).
> > 
> 
> I worked the fix back in May.   Kashyap is generating the patch's, and I'm reviewing them.

Reviewing or actually changing them?  Signed-off-by: is for alterations.
Reviewed-by: is for reviews.

James