From: Chandra Seetharaman <sekharan@us.ibm.com>
To: "Moger, Babu" <Babu.Moger@lsi.com>
Cc: "'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>,
"'dm-devel@redhat.com'" <dm-devel@redhat.com>,
"Chauhan, Vijay" <Vijay.Chauhan@lsi.com>,
"Stankey, Robert" <Robert.Stankey@lsi.com>,
"Dachepalli, Sudhir" <Sudhir.Dachepalli@lsi.com>
Subject: Re: [PATCH][RESUBMIT] scsi_dh_rdac: Fix for returning correct mode select cmd return info
Date: Fri, 28 Aug 2009 10:50:51 -0700 [thread overview]
Message-ID: <1251481851.20333.3.camel@chandra-ubuntu> (raw)
In-Reply-To: <E463DF2B2E584B4A82673F53D62C2EF474C65F39@cosmail01.lsi.com>
On Fri, 2009-08-28 at 08:18 -0600, Moger, Babu wrote:
> The function mode_select_handle_sense returns SCSI_DH_OK even when there is a sense code which is incorrect. Removing it so that it returns SCSI_DH_IO when there is sense that is not handled by this function.
>
> Signed-off-by: Babu Moger <babu.moger@lsi.com>
> Reviewed-by: Vijay Chauhan <vijay.chauhan@lsi.com>
> Reviewed-by: Bob Stankey <Robert.stankey@lsi.com>
Reviewed-by: Chandra Seetharaman <sekharan@us.ibm.com>
>
> ---
> --- linux-2.6.31-rc5/drivers/scsi/device_handler/scsi_dh_rdac.c.orig 2009-08-22 06:20:45.000000000 -0500
> +++ linux-2.6.31-rc5/drivers/scsi/device_handler/scsi_dh_rdac.c 2009-08-22 06:18:36.000000000 -0500
> @@ -455,8 +455,6 @@ static int mode_select_handle_sense(stru
> if (!ret)
> goto done;
>
> - err = SCSI_DH_OK;
> -
> switch (sense_hdr.sense_key) {
> case NO_SENSE:
> case ABORTED_COMMAND:
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-08-28 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-28 14:18 [PATCH][RESUBMIT] scsi_dh_rdac: Fix for returning correct mode select cmd return info Moger, Babu
2009-08-28 17:50 ` Chandra Seetharaman [this message]
2009-09-10 21:54 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251481851.20333.3.camel@chandra-ubuntu \
--to=sekharan@us.ibm.com \
--cc=Babu.Moger@lsi.com \
--cc=Robert.Stankey@lsi.com \
--cc=Sudhir.Dachepalli@lsi.com \
--cc=Vijay.Chauhan@lsi.com \
--cc=dm-devel@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sekharan@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox