[PATCH][RESUBMIT] scsi_dh_rdac: Fix for returning correct mode select cmd return info

[PATCH][RESUBMIT] scsi_dh_rdac: Fix for returning correct mode select cmd return info

[Moger, Babu]

The function mode_select_handle_sense returns SCSI_DH_OK even when there is a sense code which is incorrect. Removing it so that it returns SCSI_DH_IO when there is sense that is not handled by this function.

Signed-off-by: Babu Moger <babu.moger@lsi.com>
Reviewed-by: Vijay Chauhan <vijay.chauhan@lsi.com>
Reviewed-by: Bob Stankey <Robert.stankey@lsi.com>

---
--- linux-2.6.31-rc5/drivers/scsi/device_handler/scsi_dh_rdac.c.orig	2009-08-22 06:20:45.000000000 -0500
+++ linux-2.6.31-rc5/drivers/scsi/device_handler/scsi_dh_rdac.c	2009-08-22 06:18:36.000000000 -0500
@@ -455,8 +455,6 @@ static int mode_select_handle_sense(stru
 	if (!ret)
 		goto done;
 
-	err = SCSI_DH_OK;
-
 	switch (sense_hdr.sense_key) {
 	case NO_SENSE:
 	case ABORTED_COMMAND:

Re: [PATCH][RESUBMIT] scsi_dh_rdac: Fix for returning correct mode select cmd return info

[Chandra Seetharaman]

On Fri, 2009-08-28 at 08:18 -0600, Moger, Babu wrote:
> The function mode_select_handle_sense returns SCSI_DH_OK even when there is a sense code which is incorrect. Removing it so that it returns SCSI_DH_IO when there is sense that is not handled by this function.
> 
> Signed-off-by: Babu Moger <babu.moger@lsi.com>
> Reviewed-by: Vijay Chauhan <vijay.chauhan@lsi.com>
> Reviewed-by: Bob Stankey <Robert.stankey@lsi.com>

Reviewed-by: Chandra Seetharaman <sekharan@us.ibm.com>

> 
> ---
> --- linux-2.6.31-rc5/drivers/scsi/device_handler/scsi_dh_rdac.c.orig	2009-08-22 06:20:45.000000000 -0500
> +++ linux-2.6.31-rc5/drivers/scsi/device_handler/scsi_dh_rdac.c	2009-08-22 06:18:36.000000000 -0500
> @@ -455,8 +455,6 @@ static int mode_select_handle_sense(stru
>  	if (!ret)
>  		goto done;
> 
> -	err = SCSI_DH_OK;
> -
>  	switch (sense_hdr.sense_key) {
>  	case NO_SENSE:
>  	case ABORTED_COMMAND:
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH][RESUBMIT] scsi_dh_rdac: Fix for returning correct mode select cmd return info

[Moger, Babu]

James,
   Can you please pick this up for next scsi update.. I have made sure that checkpatch.pl runs fine on this . ):
Thanks
Babu Moger 

> -----Original Message-----
> From: Chandra Seetharaman [mailto:sekharan@us.ibm.com]
> Sent: Friday, August 28, 2009 12:51 PM
> To: Moger, Babu
> Cc: 'linux-scsi@vger.kernel.org'; 'dm-devel@redhat.com'; Chauhan,
> Vijay; Stankey, Robert; Dachepalli, Sudhir
> Subject: Re: [PATCH][RESUBMIT] scsi_dh_rdac: Fix for returning correct
> mode select cmd return info
> 
> 
> On Fri, 2009-08-28 at 08:18 -0600, Moger, Babu wrote:
> > The function mode_select_handle_sense returns SCSI_DH_OK even when
> there is a sense code which is incorrect. Removing it so that it
> returns SCSI_DH_IO when there is sense that is not handled by this
> function.
> >
> > Signed-off-by: Babu Moger <babu.moger@lsi.com>
> > Reviewed-by: Vijay Chauhan <vijay.chauhan@lsi.com>
> > Reviewed-by: Bob Stankey <Robert.stankey@lsi.com>
> 
> Reviewed-by: Chandra Seetharaman <sekharan@us.ibm.com>
> 
> >
> > ---
> > --- linux-2.6.31-rc5/drivers/scsi/device_handler/scsi_dh_rdac.c.orig
> 	2009-08-22 06:20:45.000000000 -0500
> > +++ linux-2.6.31-rc5/drivers/scsi/device_handler/scsi_dh_rdac.c	2009-
> 08-22 06:18:36.000000000 -0500
> > @@ -455,8 +455,6 @@ static int mode_select_handle_sense(stru
> >  	if (!ret)
> >  		goto done;
> >
> > -	err = SCSI_DH_OK;
> > -
> >  	switch (sense_hdr.sense_key) {
> >  	case NO_SENSE:
> >  	case ABORTED_COMMAND:
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-scsi"
> in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html