* Re: linux-next: scsi-post-merge tree build failure
[not found] ` <20090908181221.e8f98215.sfr@canb.auug.org.au>
@ 2009-09-08 15:48 ` James Bottomley
0 siblings, 0 replies; only message in thread
From: James Bottomley @ 2009-09-08 15:48 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, linux-kernel, Jayamohan Kallickal, Mike Christie,
linux-scsi
On Tue, 2009-09-08 at 18:12 +1000, Stephen Rothwell wrote:
> Hi James,
>
> On Mon, 7 Sep 2009 20:06:46 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Today's linux-next build (powerpc allyesconfig) failed like this:
> >
> > drivers/scsi/be2iscsi/be_main.c: In function 'hwi_write_buffer':
> > drivers/scsi/be2iscsi/be_main.c:1481: error: implicit declaration of function 'virt_to_bus'
> >
> > Caused by commit 9316dc3deb9675c674f96a0c6fb74ccc6c497fae ("[SCSI]
> > be2iscsi: add 10Gbps iSCSI - BladeEngine 2 driver") which I have reverted
> > for today.
>
> The driver needs to depend on CONFIG_VIRT_TO_BUS if it needs to use
> virt_to_bus(). That will prevent it from building on some platforms
> (like powerpc) that do not implement virt_to_bus() and its brothers.
Actually, this is a modern hardware iSCSI card not some legacy piece of
hardware: it needs to use the proper API for this.
James
^ permalink raw reply [flat|nested] only message in thread