From: James Bottomley <James.Bottomley@suse.de>
To: Julia Lawall <julia@diku.dk>
Cc: djwong@us.ibm.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drivers/scsi/libsas: Use SAM_GOOD
Date: Tue, 29 Sep 2009 14:12:26 +0000 [thread overview]
Message-ID: <1254233546.3942.36.camel@mulgrave.site> (raw)
In-Reply-To: <Pine.LNX.4.64.0909290759420.29620@ask.diku.dk>
On Tue, 2009-09-29 at 08:00 +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The field stat->stat should be compared to SAM_GOOD, not SAM_STAT_GOOD, as
> done elsewhere in the same function. Both constants have the same value.
Actually, I'd like to see us go the other way. Use the standard SCSI
defined SAM_STAT macros in libsas instead of its hand rolled
equivalents. This would mean modifying aic94xx/aic94xx_task.c and
libsas.h as well.
Thanks,
James
prev parent reply other threads:[~2009-09-29 14:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 6:00 [PATCH] drivers/scsi/libsas: Use SAM_GOOD Julia Lawall
2009-09-29 14:12 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254233546.3942.36.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=djwong@us.ibm.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox