[PATCH] drivers/scsi/libsas: Use SAM_GOOD

[PATCH] drivers/scsi/libsas: Use SAM_GOOD

[Julia Lawall]

From: Julia Lawall <julia@diku.dk>

The field stat->stat should be compared to SAM_GOOD, not SAM_STAT_GOOD, as
done elsewhere in the same function.  Both constants have the same value.

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/scsi/libsas/sas_ata.c       |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index e155011..c77b3f9 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -112,7 +112,7 @@ static void sas_ata_task_done(struct sas_task *task)
 		dev->sata_dev.sstatus = resp->sstatus;
 		dev->sata_dev.serror = resp->serror;
 		dev->sata_dev.scontrol = resp->scontrol;
-	} else if (stat->stat != SAM_STAT_GOOD) {
+	} else if (stat->stat != SAM_GOOD) {
 		ac = sas_to_ata_err(stat);
 		if (ac) {
 			SAS_DPRINTK("%s: SAS error %x\n", __func__,

Re: [PATCH] drivers/scsi/libsas: Use SAM_GOOD

[James Bottomley]

On Tue, 2009-09-29 at 08:00 +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
> 
> The field stat->stat should be compared to SAM_GOOD, not SAM_STAT_GOOD, as
> done elsewhere in the same function.  Both constants have the same value.

Actually, I'd like to see us go the other way.  Use the standard SCSI
defined SAM_STAT macros in libsas instead of its hand rolled
equivalents.  This would mean modifying aic94xx/aic94xx_task.c and
libsas.h as well.

Thanks,

James