From: James Bottomley <James.Bottomley@suse.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Yang Hongyang <yanghy@cn.fujitsu.com>, Alan Cox <alan@redhat.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 02/34] move atp870u_remove to .devexit.text
Date: Thu, 01 Oct 2009 14:20:02 +0000 [thread overview]
Message-ID: <1254406802.3885.1.camel@mulgrave.site> (raw)
In-Reply-To: <1254385718-14254-2-git-send-email-u.kleine-koenig@pengutronix.de>
On Thu, 2009-10-01 at 10:28 +0200, Uwe Kleine-König wrote:
> The function atp870u_remove is used only wrapped by __devexit_p so define
> it using __devexit.
What's the justification for this?
Given that practically every kernel on the planet is hotplug enabled
these days and that the savings on the very few that aren't from
discarding the devexit section is at most a page or two (and even arm
says they don't care about that), there doesn't seem to be any point
making these changes. In fact, I think we can just kill devinit and
devexit as section markers.
James
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-10-01 14:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091001082607.GA2181@pengutronix.de>
2009-10-01 8:28 ` [PATCH 02/34] move atp870u_remove to .devexit.text Uwe Kleine-König
2009-10-01 14:20 ` James Bottomley [this message]
2009-10-02 19:13 ` Uwe Kleine-König
2009-10-01 8:28 ` [PATCH 08/34] move initio_remove_one " Uwe Kleine-König
2009-10-01 8:28 ` [PATCH 10/34] don't use __devexit_p to wrap lasi700_driver_remove Uwe Kleine-König
2009-10-01 8:28 ` [PATCH 12/34] move megaraid_detach_one to .devexit.text Uwe Kleine-König
2009-10-01 8:28 ` [PATCH 18/34] don't use __devexit_p to wrap NCR_Q720_remove Uwe Kleine-König
2009-10-01 8:28 ` [PATCH 23/34] don't use __devexit_p to wrap sgiwd93_remove Uwe Kleine-König
2009-10-01 8:28 ` [PATCH 25/34] don't use __devexit_p to wrap snirm710_driver_remove Uwe Kleine-König
2009-10-01 8:28 ` [PATCH 27/34] move stex_remove to .devexit.text Uwe Kleine-König
2009-10-01 8:28 ` [PATCH 32/34] don't use __devexit_p to wrap zalon_remove Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254406802.3885.1.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yanghy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox