From: Boaz Harrosh <bharrosh@panasas.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
open-osd <osd-dev@open-osd.org>
Subject: [PATCH 3/9] osduld: Ref-counting bug fix
Date: Mon, 16 Nov 2009 20:44:02 +0200 [thread overview]
Message-ID: <1258397042-32653-1-git-send-email-bharrosh@panasas.com> (raw)
In-Reply-To: <4B019BEC.3080909@panasas.com>
If scsi has released the device (logout), and exofs has last
reference on the osduld_device it will be freed by
osd_uld_release() within the call to fput(). But this will
oops in cdev_release() which is called after the fops->release.
(cdev is embedded within osduld_device). __uld_get/put pair
makes sure we have a cdev for the duration of fput()
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
drivers/scsi/osd/osd_uld.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/osd/osd_uld.c b/drivers/scsi/osd/osd_uld.c
index 0bdef33..1ea6447 100644
--- a/drivers/scsi/osd/osd_uld.c
+++ b/drivers/scsi/osd/osd_uld.c
@@ -224,7 +224,15 @@ void osduld_put_device(struct osd_dev *od)
BUG_ON(od->scsi_device != oud->od.scsi_device);
+ /* If scsi has released the device (logout), and exofs has last
+ * reference on oud it will be freed by above osd_uld_release
+ * within fput below. But this will oops in cdev_release which
+ * is called after the fops->release. __uld_get/put pair makes
+ * sure we have a cdev for the duration of fput
+ */
+ __uld_get(oud);
fput(od->file);
+ __uld_put(oud);
kfree(od);
}
}
--
1.6.5.2
next prev parent reply other threads:[~2009-11-16 18:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 18:37 [PATCHES 0/9] osd patches for 2.6.33 merge window - resend Boaz Harrosh
2009-11-16 18:39 ` [PATCH 1/9] libosd: osd_dev_is_ver1 - Minor API cleanup Boaz Harrosh
2009-11-16 18:41 ` [PATCH 2/9] libosd: osd_sense: OSD_CFO_PERMISSIONS Boaz Harrosh
2009-11-16 18:44 ` Boaz Harrosh [this message]
2009-11-16 18:45 ` [PATCH 4/9] osduld: Use device->release instead of internal kref Boaz Harrosh
2009-11-16 19:52 ` James Bottomley
2009-11-16 18:45 ` [PATCH 5/9] libosd: osd_dev_info: Unique Identification of an OSD device Boaz Harrosh
2009-11-16 18:47 ` [PATCH 6/9] libosd: bug in osd_req_decode_sense_full() Boaz Harrosh
2009-11-16 18:47 ` [PATCH 7/9] libosd: Bugfix of error handling in attributes-list decoding Boaz Harrosh
2009-11-16 18:48 ` [PATCH 8/9] libosd: Error handling revamped Boaz Harrosh
2009-11-16 18:49 ` [PATCH 9/9] osd_protocol.h: Add missing #include Boaz Harrosh
2009-11-16 18:57 ` Martin Michlmayr
2009-11-16 19:01 ` Boaz Harrosh
2009-11-16 19:09 ` Martin Michlmayr
2009-11-16 20:01 ` James Bottomley
2009-11-17 7:54 ` Boaz Harrosh
2009-11-17 13:50 ` [PATCH 10/10] osduld: No need to use dev_set_drvdata on embedded devices Boaz Harrosh
2009-11-23 16:34 ` [osd-dev] [PATCHES 0/9] osd patches for 2.6.33 merge window - resend Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258397042-32653-1-git-send-email-bharrosh@panasas.com \
--to=bharrosh@panasas.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=osd-dev@open-osd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox