From: James Bottomley <James.Bottomley@suse.de>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>, open-osd <osd-dev@open-osd.org>
Subject: Re: [PATCH 4/9] osduld: Use device->release instead of internal kref
Date: Mon, 16 Nov 2009 13:52:22 -0600 [thread overview]
Message-ID: <1258401142.2517.226.camel@mulgrave.site> (raw)
In-Reply-To: <1258397115-32682-1-git-send-email-bharrosh@panasas.com>
On Mon, 2009-11-16 at 20:45 +0200, Boaz Harrosh wrote:
> + dev_set_drvdata(&oud->class_dev, oud);
This is incredibly minor, but since the device is now embedded in oud,
you can simply cast out to get the containing structure:
oud = container_of(dev, struct osd_uld_device, class_dev);
It's not worth redoing the patch set over, but it is worth remembering
for the future.
James
next prev parent reply other threads:[~2009-11-16 19:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 18:37 [PATCHES 0/9] osd patches for 2.6.33 merge window - resend Boaz Harrosh
2009-11-16 18:39 ` [PATCH 1/9] libosd: osd_dev_is_ver1 - Minor API cleanup Boaz Harrosh
2009-11-16 18:41 ` [PATCH 2/9] libosd: osd_sense: OSD_CFO_PERMISSIONS Boaz Harrosh
2009-11-16 18:44 ` [PATCH 3/9] osduld: Ref-counting bug fix Boaz Harrosh
2009-11-16 18:45 ` [PATCH 4/9] osduld: Use device->release instead of internal kref Boaz Harrosh
2009-11-16 19:52 ` James Bottomley [this message]
2009-11-16 18:45 ` [PATCH 5/9] libosd: osd_dev_info: Unique Identification of an OSD device Boaz Harrosh
2009-11-16 18:47 ` [PATCH 6/9] libosd: bug in osd_req_decode_sense_full() Boaz Harrosh
2009-11-16 18:47 ` [PATCH 7/9] libosd: Bugfix of error handling in attributes-list decoding Boaz Harrosh
2009-11-16 18:48 ` [PATCH 8/9] libosd: Error handling revamped Boaz Harrosh
2009-11-16 18:49 ` [PATCH 9/9] osd_protocol.h: Add missing #include Boaz Harrosh
2009-11-16 18:57 ` Martin Michlmayr
2009-11-16 19:01 ` Boaz Harrosh
2009-11-16 19:09 ` Martin Michlmayr
2009-11-16 20:01 ` James Bottomley
2009-11-17 7:54 ` Boaz Harrosh
2009-11-17 13:50 ` [PATCH 10/10] osduld: No need to use dev_set_drvdata on embedded devices Boaz Harrosh
2009-11-23 16:34 ` [osd-dev] [PATCHES 0/9] osd patches for 2.6.33 merge window - resend Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258401142.2517.226.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=bharrosh@panasas.com \
--cc=linux-scsi@vger.kernel.org \
--cc=osd-dev@open-osd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox