Re: scsi LLD implementation question

Re: scsi LLD implementation question

[James Bottomley]

Cc to linux-scsi added because that's the list that best handles these
type of questions.

On Thu, 2011-02-24 at 20:13 -0800, va stg2010 wrote:
> Hi,
> I am working on a driver  for scsi initiator HBA driver for  linux.
> Have an implementation question. Once the commands are received
> into .queuecommand  callback from linux-scsi, I insert them into a
> queue maintained  locally in my driver until the responses comes back
> from target.  The responses when posted later by an interrupt handler
> are eventually processed by a kthread which "iterates"  through this
> queue to post responses back to linux-scsi.

Actually, doing actual internal queueing isn't a good idea:  two queue
confuse the block elevators and only usually serve to increase latency.
If by "queue" you just mean a list of pending commands that have already
been issued to the driver which you need to find again by some
identifier again when the interrupt driven completion is posted, then
using the block tags for this is usually optimal (depending on how many
bits you have for the completion identifier).

>  Question about this queue:
> Is it efficient to have one single queue for all the disks or  its
> more efficient to have separate queue for each disk and separate
> response processing kthreads ?

Having a kthread process responses is generally not a good idea because
completions will come in at interrupt level ... you need a context
switch to get to a thread and this costs latency.  The idea of done
processing in SCSI is to identify the scsi_cmnd as quickly as possible
and post it.  All back end SCSI processing is done in the block softirq
(a level between hard interrupt and user context), again to keep latency
low.  That also means that the kthread architecture is wrong because
it's difficult for the kernel to go hardirq->user->softirq without
adding an extra interrupt latency (usually a clock tick).

If you want a "threaded" response in a multiqueue card using MSIs, then
you bind the MSIs to CPU groups and use the hardware interrupt context
as the threading (I think drivers like lpfc already do this).  The best
performance is actually observed when the MSI comes back in on the same
CPU that issued the I/O because the cache is still hot.  The block keeps
an rq->cpu to tag this which internal HBA setup can use for programming
MSI completions.

James

Re: scsi LLD implementation question

[Bart Van Assche]

On Fri, Feb 25, 2011 at 2:37 PM, James Bottomley
<James.Bottomley@suse.de> wrote:
> Having a kthread process responses is generally not a good idea because
> completions will come in at interrupt level ... you need a context
> switch to get to a thread and this costs latency.  The idea of done
> processing in SCSI is to identify the scsi_cmnd as quickly as possible
> and post it.  All back end SCSI processing is done in the block softirq
> (a level between hard interrupt and user context), again to keep latency
> low.  That also means that the kthread architecture is wrong because
> it's difficult for the kernel to go hardirq->user->softirq without
> adding an extra interrupt latency (usually a clock tick).
>
> If you want a "threaded" response in a multiqueue card using MSIs, then
> you bind the MSIs to CPU groups and use the hardware interrupt context
> as the threading (I think drivers like lpfc already do this).  The best
> performance is actually observed when the MSI comes back in on the same
> CPU that issued the I/O because the cache is still hot.  The block keeps
> an rq->cpu to tag this which internal HBA setup can use for programming
> MSI completions.

The above sounds like great advice if the processing time is
reasonably short. But what if the processing time can be anything
between e.g. a microsecond and twenty minutes ?

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: scsi LLD implementation question

[James Bottomley]

On Fri, 2011-02-25 at 18:12 +0100, Bart Van Assche wrote:
> On Fri, Feb 25, 2011 at 2:37 PM, James Bottomley
> <James.Bottomley@suse.de> wrote:
> > Having a kthread process responses is generally not a good idea because
> > completions will come in at interrupt level ... you need a context
> > switch to get to a thread and this costs latency.  The idea of done
> > processing in SCSI is to identify the scsi_cmnd as quickly as possible
> > and post it.  All back end SCSI processing is done in the block softirq
> > (a level between hard interrupt and user context), again to keep latency
> > low.  That also means that the kthread architecture is wrong because
> > it's difficult for the kernel to go hardirq->user->softirq without
> > adding an extra interrupt latency (usually a clock tick).
> >
> > If you want a "threaded" response in a multiqueue card using MSIs, then
> > you bind the MSIs to CPU groups and use the hardware interrupt context
> > as the threading (I think drivers like lpfc already do this).  The best
> > performance is actually observed when the MSI comes back in on the same
> > CPU that issued the I/O because the cache is still hot.  The block keeps
> > an rq->cpu to tag this which internal HBA setup can use for programming
> > MSI completions.
> 
> The above sounds like great advice if the processing time is
> reasonably short. But what if the processing time can be anything
> between e.g. a microsecond and twenty minutes ?

Well, what processing?  SCSI LLDs are data shifting engines; there's not
a lot of extra stuff to do.  If you mean things like integrity
verification, they tend to be done inline adding directly to latency as
a cost of turning on integrity.  If you mean something like
excrutiatingly slow PIO just to capture the data, then that's up to the
LLD ... but most do it in-line (bogging down the whole system) primarily
because timing tends to be critical to avoid FIFO overruns (the lesson
being to avoid those cards).

Can you give an example?  I can't really think of any processing that's
so huge it would require threaded offloading.  The main point I was
making is that offloading to a thread between HW irq and SCSI done adds
enormously to latency because of the way done completions are processed
in softirq context.  If that latency is just a drop in the ocean
compared to the processing, then sure, offload it.

James


James

Re: scsi LLD implementation question

[Bart Van Assche]

On Fri, Feb 25, 2011 at 6:20 PM, James Bottomley
<James.Bottomley@suse.de> wrote:
> On Fri, 2011-02-25 at 18:12 +0100, Bart Van Assche wrote:
>> On Fri, Feb 25, 2011 at 2:37 PM, James Bottomley
>> <James.Bottomley@suse.de> wrote:
>> > Having a kthread process responses is generally not a good idea because
>> > completions will come in at interrupt level ... you need a context
>> > switch to get to a thread and this costs latency.  The idea of done
>> > processing in SCSI is to identify the scsi_cmnd as quickly as possible
>> > and post it.  All back end SCSI processing is done in the block softirq
>> > (a level between hard interrupt and user context), again to keep latency
>> > low.  That also means that the kthread architecture is wrong because
>> > it's difficult for the kernel to go hardirq->user->softirq without
>> > adding an extra interrupt latency (usually a clock tick).
>> >
>> > If you want a "threaded" response in a multiqueue card using MSIs, then
>> > you bind the MSIs to CPU groups and use the hardware interrupt context
>> > as the threading (I think drivers like lpfc already do this).  The best
>> > performance is actually observed when the MSI comes back in on the same
>> > CPU that issued the I/O because the cache is still hot.  The block keeps
>> > an rq->cpu to tag this which internal HBA setup can use for programming
>> > MSI completions.
>>
>> The above sounds like great advice if the processing time is
>> reasonably short. But what if the processing time can be anything
>> between e.g. a microsecond and twenty minutes ?
>
> Well, what processing?  SCSI LLDs are data shifting engines; there's not
> a lot of extra stuff to do.  If you mean things like integrity
> verification, they tend to be done inline adding directly to latency as
> a cost of turning on integrity.  If you mean something like
> excrutiatingly slow PIO just to capture the data, then that's up to the
> LLD ... but most do it in-line (bogging down the whole system) primarily
> because timing tends to be critical to avoid FIFO overruns (the lesson
> being to avoid those cards).
>
> Can you give an example?  I can't really think of any processing that's
> so huge it would require threaded offloading.  The main point I was
> making is that offloading to a thread between HW irq and SCSI done adds
> enormously to latency because of the way done completions are processed
> in softirq context.  If that latency is just a drop in the ocean
> compared to the processing, then sure, offload it.

I don't doubt the above is correct for SCSI initiator LLDs. I had
another context in mind - target drivers. While initiator workloads
are self-balancing because the application generating the workload and
the LLD run on the same system, that does not hold for target drivers.
How much work has to be processed by a target driver depends on the
number of initiator systems it is communicating with it and how much
I/O these are generating. With a sufficient number of initiator
systems and high-bandwidth HCA hardware it is possible that work
arrives faster on a target system than it can be processed. As an
example, it has already been observed with ib_srpt driver if it is
configured to process incoming work in softirq context that it can run
continuously for ten minutes. That means that during that time no
other tasklets nor any user space threads are run, resulting in user
feedback like "console locks up". Defining budgets for I/O processing
is not a solution in this context. Or, in other words, processing
target driver I/O in softirq context kills an important property of
the Linux kernel we all appreciate, namely that all processes on a
system are responsive at any time even on a heavily loaded system.

That experience made me wonder whether target drivers for
high-bandwidth HCAs should ever process I/O in IRQ or softirq context.

Regarding LLD drivers and offloading processing to thread context: if
this really adds enormously to latency that's a bug that should be
fixed. Please keep in mind that one of the basic design choices behind
real-time Linux kernels is to offload all interrupt processing to
thread context [1]. On systems running a real-time Linux kernel in its
default configuration all completions will be processed in thread
context.

[1] Jake Edge, Moving interrupts to threads, LWN.net, October 8, 2008
(http://lwn.net/Articles/302043/).

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: scsi LLD implementation question

[James Bottomley]

On Fri, 2011-02-25 at 11:19 -0800, va stg2010 wrote:
> Thanks !
> There is a 32-bit tag  to refer back  the queue(for pending commands)
> when responses are posted back by HBA.   Suppose the HBA is  receiving
> commands from multiple initiators because the host has virtualized
> initiator environment, now in this case  one single large queue is
> good enough or there should be pending-commands-queue per virtual
> initiator or pending-command-queue per disks.

It doesn't have to be virtualised; this is the normal situation on a
SAN.  For a pending queue, the question is merely how to do efficient
lookup.  Some drivers use a fixed offset list (with the offset in the
completion tag) ... I suppose a radix tree would be a good way to go for
particularly large pending queues.

> Just want to minimize the  locking contentions  and  maximize
> parallelism in  SCSI  I/O to multiple disks from multiple virtual
> initiators via my HBA.

To be honest, fixes offset lists are best then ... they can operated
locklessly.

James