[PATCH] [SCSI] aacraid: Use kmemdup rather than duplicating its implementation

[PATCH] [SCSI] aacraid: Use kmemdup rather than duplicating its implementation

[Thomas Meyer]

The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---

diff -u -p a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c
--- a/drivers/scsi/aacraid/commctrl.c 2011-11-07 19:38:06.463566391 +0100
+++ b/drivers/scsi/aacraid/commctrl.c 2011-11-08 10:53:23.848146953 +0100
@@ -631,15 +631,14 @@ static int aac_send_raw_srb(struct aac_d
 			}
 		} else {
 			struct user_sgmap* usg;
-			usg = kmalloc(actual_fibsize - sizeof(struct aac_srb)
-			  + sizeof(struct sgmap), GFP_KERNEL);
+			usg = kmemdup(upsg,
+				      actual_fibsize - sizeof(struct aac_srb) + sizeof(struct sgmap),
+				      GFP_KERNEL);
 			if (!usg) {
 				dprintk((KERN_DEBUG"aacraid: Allocation error in Raw SRB command\n"));
 				rcode = -ENOMEM;
 				goto cleanup;
 			}
-			memcpy (usg, upsg, actual_fibsize - sizeof(struct aac_srb)
-			  + sizeof(struct sgmap));
 			actual_fibsize = actual_fibsize64;
 
 			for (i = 0; i < usg->count; i++) {

RE: [PATCH] [SCSI] aacraid: Use kmemdup rather than duplicating its implementation

[Mark Salyzyn]

Ack

This driver is maintained by Achim Leubner
<Achim_Leubner@pmc-sierra.com> and Mahesh Rajashekhara
<Mahesh_Rajashekhara@pmc-sierra.com>. I have added them so that either
one of them can have the opportunity to respond.

Sincerely -- Mark Salyzyn

-----Original Message-----
From: linux-scsi-owner@vger.kernel.org
[mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of Thomas Meyer
Sent: Thursday, November 17, 2011 5:44 PM
To: JBottomley@parallels.com; linux-scsi@vger.kernel.org;
linux-kernel@vger.kernel.org
Subject: [PATCH] [SCSI] aacraid: Use kmemdup rather than duplicating its
implementation

The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---

diff -u -p a/drivers/scsi/aacraid/commctrl.c
b/drivers/scsi/aacraid/commctrl.c
--- a/drivers/scsi/aacraid/commctrl.c 2011-11-07 19:38:06.463566391
+0100
+++ b/drivers/scsi/aacraid/commctrl.c 2011-11-08 10:53:23.848146953
+0100
@@ -631,15 +631,14 @@ static int aac_send_raw_srb(struct aac_d
 			}
 		} else {
 			struct user_sgmap* usg;
-			usg = kmalloc(actual_fibsize - sizeof(struct
aac_srb)
-			  + sizeof(struct sgmap), GFP_KERNEL);
+			usg = kmemdup(upsg,
+				      actual_fibsize - sizeof(struct
aac_srb) + sizeof(struct sgmap),
+				      GFP_KERNEL);
 			if (!usg) {
 				dprintk((KERN_DEBUG"aacraid: Allocation
error in Raw SRB command\n"));
 				rcode = -ENOMEM;
 				goto cleanup;
 			}
-			memcpy (usg, upsg, actual_fibsize -
sizeof(struct aac_srb)
-			  + sizeof(struct sgmap));
 			actual_fibsize = actual_fibsize64;
 
 			for (i = 0; i < usg->count; i++) {

RE: [PATCH] [SCSI] aacraid: Use kmemdup rather than duplicating its implementation

[Joe Perches]

> -----Original Message-----
> The semantic patch that makes this change is available
> in scripts/coccinelle/api/memdup.cocci.
> 
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
> 
> diff -u -p a/drivers/scsi/aacraid/commctrl.c

On Tue, 2011-11-22 at 06:24 -0800, Mark Salyzyn wrote:
> This driver is maintained by Achim Leubner
> <Achim_Leubner@pmc-sierra.com> and Mahesh Rajashekhara
> <Mahesh_Rajashekhara@pmc-sierra.com>. I have added them so that either
> one of them can have the opportunity to respond.
 
Really?  MAINTAINERS has:

AACRAID SCSI RAID DRIVER
M:	Adaptec OEM Raid Solutions <aacraid@adaptec.com>
L:	linux-scsi@vger.kernel.org
W:	http://www.adaptec.com/
S:	Supported
F:	Documentation/scsi/aacraid.txt
F:	drivers/scsi/aacraid/

Should either or both Achim or Mahesh be added?

RE: [PATCH] [SCSI] aacraid: Use kmemdup rather than duplicating its implementation

[Mark Salyzyn]

aacraid@adaptec.com goes to them, I may have done a boo-boo by exposing
the current underlying addressees. As it stands the patch was not
addressed to any of the aacraid maintainers. The correct answer would
have been for me to Cc: aacraid@adaptec.com.

The MAINTAINERS file is *correct*. It has dealt with the arbitrary
transition of individual assigned maintainers within Adaptec (now PMC)
for nearly a decade now.

Sincerely -- Mark Salyzyn (former maintainer, interested party now)

-----Original Message-----
From: linux-scsi-owner@vger.kernel.org
[mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of Joe Perches
Sent: Tuesday, November 22, 2011 10:57 AM
To: Mark Salyzyn
Cc: Thomas Meyer; JBottomley@parallels.com; linux-scsi@vger.kernel.org;
linux-kernel@vger.kernel.org; Achim Leubner; Mahesh Rajashekhara
Subject: RE: [PATCH] [SCSI] aacraid: Use kmemdup rather than duplicating
its implementation

> -----Original Message-----
> The semantic patch that makes this change is available
> in scripts/coccinelle/api/memdup.cocci.
> 
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
> 
> diff -u -p a/drivers/scsi/aacraid/commctrl.c

On Tue, 2011-11-22 at 06:24 -0800, Mark Salyzyn wrote:
> This driver is maintained by Achim Leubner
> <Achim_Leubner@pmc-sierra.com> and Mahesh Rajashekhara
> <Mahesh_Rajashekhara@pmc-sierra.com>. I have added them so that either
> one of them can have the opportunity to respond.
 
Really?  MAINTAINERS has:

AACRAID SCSI RAID DRIVER
M:	Adaptec OEM Raid Solutions <aacraid@adaptec.com>
L:	linux-scsi@vger.kernel.org
W:	http://www.adaptec.com/
S:	Supported
F:	Documentation/scsi/aacraid.txt
F:	drivers/scsi/aacraid/

Should either or both Achim or Mahesh be added?