[PATCH] scsi: mark some messages as INFO/WARNING/ERROR

[PATCH] scsi: mark some messages as INFO/WARNING/ERROR

[Tom Gundersen]

This reduces the noice in

$ dmesg --kernel --level=err,warn

Signed-off-by: Tom Gundersen <teg@jklm.no>
---
 drivers/scsi/sr.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
index 5fc97d2..762039a 100644
--- a/drivers/scsi/sr.c
+++ b/drivers/scsi/sr.c
@@ -306,7 +306,7 @@ static int sr_done(struct scsi_cmnd *SCpnt)
 	struct scsi_cd *cd = scsi_cd(SCpnt->request->rq_disk);
 
 #ifdef DEBUG
-	printk("sr.c done: %x\n", result);
+	printk(KERN_DEBUG "sr.c done: %x\n", result);
 #endif
 
 	/*
@@ -416,7 +416,7 @@ static int sr_prep_fn(struct request_queue *q, struct request *rq)
 		if (!in_interrupt())
 			sr_set_blocklength(cd, 2048);
 		else
-			printk("sr: can't switch blocksize: in interrupt\n");
+			printk(KERN_WARNING "sr: can't switch blocksize: in interrupt\n");
 	}
 
 	if (s_size != 512 && s_size != 1024 && s_size != 2048) {
@@ -790,7 +790,7 @@ static void get_sectorsize(struct scsi_cd *cd)
 		case 512:
 			break;
 		default:
-			printk("%s: unsupported sector size %d.\n",
+			printk(KERN_ERR "%s: unsupported sector size %d.\n",
 			       cd->cdi.name, sector_size);
 			cd->capacity = 0;
 		}
@@ -852,7 +852,7 @@ static void get_capabilities(struct scsi_cd *cd)
 				 CDC_SELECT_DISC | CDC_SELECT_SPEED |
 				 CDC_MRW | CDC_MRW_W | CDC_RAM);
 		kfree(buffer);
-		printk("%s: scsi-1 drive\n", cd->cdi.name);
+		printk(KERN_INFO "%s: scsi-1 drive\n", cd->cdi.name);
 		return;
 	}
 
@@ -861,7 +861,7 @@ static void get_capabilities(struct scsi_cd *cd)
 	cd->readcd_known = 1;
 	cd->readcd_cdda = buffer[n + 5] & 0x01;
 	/* print some capability bits */
-	printk("%s: scsi3-mmc drive: %dx/%dx %s%s%s%s%s%s\n", cd->cdi.name,
+	printk(KERN_INFO "%s: scsi3-mmc drive: %dx/%dx %s%s%s%s%s%s\n", cd->cdi.name,
 	       ((buffer[n + 14] << 8) + buffer[n + 15]) / 176,
 	       cd->cdi.speed,
 	       buffer[n + 3] & 0x01 ? "writer " : "", /* CD Writer */
-- 
1.7.8

Re: [PATCH] scsi: mark some messages as INFO/WARNING/ERROR

[Joe Perches]

On Wed, 2011-12-07 at 17:52 +0100, Tom Gundersen wrote:
> This reduces the noice
[]
> diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
[]
> @@ -416,7 +416,7 @@ static int sr_prep_fn(struct request_queue *q, struct request *rq)
>  		if (!in_interrupt())
>  			sr_set_blocklength(cd, 2048);
>  		else
> -			printk("sr: can't switch blocksize: in interrupt\n");
> +			printk(KERN_WARNING "sr: can't switch blocksize: in interrupt\n");

Maybe this should be KERN_ERR?