* [PATCH] qla2xxx: Remove last vestiges of qla_tgt_cmd.cmd_list
@ 2014-01-31 21:11 Roland Dreier
2014-01-31 22:53 ` Nicholas A. Bellinger
0 siblings, 1 reply; 2+ messages in thread
From: Roland Dreier @ 2014-01-31 21:11 UTC (permalink / raw)
To: Nicholas A. Bellinger; +Cc: qla2xxx-upstream, target-devel, linux-scsi
From: Roland Dreier <roland@purestorage.com>
The only place this struct member is touched is in one INIT_LIST_HEAD.
Signed-off-by: Roland Dreier <roland@purestorage.com>
---
drivers/scsi/qla2xxx/qla_target.c | 2 --
drivers/scsi/qla2xxx/qla_target.h | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 38a1257e76e1..2f42b650367c 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -2593,8 +2593,6 @@ static int qlt_handle_cmd_for_atio(struct scsi_qla_host *vha,
return -ENOMEM;
}
- INIT_LIST_HEAD(&cmd->cmd_list);
-
memcpy(&cmd->atio, atio, sizeof(*atio));
cmd->state = QLA_TGT_STATE_NEW;
cmd->tgt = ha->tgt.qla_tgt;
diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h
index b33e411f28a0..f4a4beee2b96 100644
--- a/drivers/scsi/qla2xxx/qla_target.h
+++ b/drivers/scsi/qla2xxx/qla_target.h
@@ -855,7 +855,6 @@ struct qla_tgt_cmd {
uint16_t loop_id; /* to save extra sess dereferences */
struct qla_tgt *tgt; /* to save extra sess dereferences */
struct scsi_qla_host *vha;
- struct list_head cmd_list;
struct atio_from_isp atio;
};
--
1.9.rc1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] qla2xxx: Remove last vestiges of qla_tgt_cmd.cmd_list
2014-01-31 21:11 [PATCH] qla2xxx: Remove last vestiges of qla_tgt_cmd.cmd_list Roland Dreier
@ 2014-01-31 22:53 ` Nicholas A. Bellinger
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas A. Bellinger @ 2014-01-31 22:53 UTC (permalink / raw)
To: Roland Dreier; +Cc: qla2xxx-upstream, target-devel, linux-scsi
On Fri, 2014-01-31 at 13:11 -0800, Roland Dreier wrote:
> From: Roland Dreier <roland@purestorage.com>
>
> The only place this struct member is touched is in one INIT_LIST_HEAD.
>
> Signed-off-by: Roland Dreier <roland@purestorage.com>
> ---
Applied to target-pending/queue.
Thanks Roland!
--nab
> drivers/scsi/qla2xxx/qla_target.c | 2 --
> drivers/scsi/qla2xxx/qla_target.h | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 38a1257e76e1..2f42b650367c 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -2593,8 +2593,6 @@ static int qlt_handle_cmd_for_atio(struct scsi_qla_host *vha,
> return -ENOMEM;
> }
>
> - INIT_LIST_HEAD(&cmd->cmd_list);
> -
> memcpy(&cmd->atio, atio, sizeof(*atio));
> cmd->state = QLA_TGT_STATE_NEW;
> cmd->tgt = ha->tgt.qla_tgt;
> diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h
> index b33e411f28a0..f4a4beee2b96 100644
> --- a/drivers/scsi/qla2xxx/qla_target.h
> +++ b/drivers/scsi/qla2xxx/qla_target.h
> @@ -855,7 +855,6 @@ struct qla_tgt_cmd {
> uint16_t loop_id; /* to save extra sess dereferences */
> struct qla_tgt *tgt; /* to save extra sess dereferences */
> struct scsi_qla_host *vha;
> - struct list_head cmd_list;
>
> struct atio_from_isp atio;
> };
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-31 22:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-31 21:11 [PATCH] qla2xxx: Remove last vestiges of qla_tgt_cmd.cmd_list Roland Dreier
2014-01-31 22:53 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox