[PATCH] megaraid_sas: make the log message about rescanning more informative.

[PATCH] megaraid_sas: make the log message about rescanning more informative.

[Jasper Spaans]

Hi,

I was working on one of our servers, and saw the following interesting
message in dmesg:

[20961024.720972] scanning ...

This scared me somewhat. Please find a patch to make it easier to see where
this message is coming from.

Cheers,
Jasper

---
 drivers/scsi/megaraid/megaraid_sas_base.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 1f0ca68..3457289 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -5461,7 +5461,7 @@ megasas_aen_polling(struct work_struct *work)
 	}
 
 	if (doscan) {
-		printk(KERN_INFO "scanning ...\n");
+		printk(KERN_INFO "Rescanning MegaRAID devices ...\n");
 		megasas_get_pd_list(instance);
 		for (i = 0; i < MEGASAS_MAX_PD_CHANNELS; i++) {
 			for (j = 0; j < MEGASAS_MAX_DEV_PER_CHANNEL; j++) {
-- 
1.7.9.5


-- 
 /\____/\   ir. Jasper Spaans // Lead Developer www.FoxDetACT.com
 \   (_)/   Fox-IT - For a more secure society!
  \    X    T: +31-15-2847999       
   \  / \   M: +31-6-41588725
    \/      KvK Haaglanden 27301624

RE: [PATCH] megaraid_sas: make the log message about rescanning more informative.

[Saxena, Sumit]

>-----Original Message-----
>From: Jasper Spaans [mailto:spaans@fox-it.com]
>Sent: Friday, October 25, 2013 5:53 PM
>To: DL-MegaRAID Linux
>Cc: linux-scsi@vger.kernel.org
>Subject: [PATCH] megaraid_sas: make the log message about rescanning
>more informative.
>
>Hi,
>
>I was working on one of our servers, and saw the following interesting
>message in dmesg:
>
>[20961024.720972] scanning ...
>
>This scared me somewhat. Please find a patch to make it easier to see where
>this message is coming from.
>
>Cheers,
>Jasper
>
>---
> drivers/scsi/megaraid/megaraid_sas_base.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
>b/drivers/scsi/megaraid/megaraid_sas_base.c
>index 1f0ca68..3457289 100644
>--- a/drivers/scsi/megaraid/megaraid_sas_base.c
>+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>@@ -5461,7 +5461,7 @@ megasas_aen_polling(struct work_struct *work)
> 	}
>
> 	if (doscan) {
>-		printk(KERN_INFO "scanning ...\n");
>+		printk(KERN_INFO "Rescanning MegaRAID devices ...\n");
> 		megasas_get_pd_list(instance);
> 		for (i = 0; i < MEGASAS_MAX_PD_CHANNELS; i++) {
> 			for (j = 0; j < MEGASAS_MAX_DEV_PER_CHANNEL;
>j++) {
>--
>1.7.9.5
Acked-by: Sumit Saxena <sumit.saxena@lsi.com>

Sumit
>
>
>--
> /\____/\   ir. Jasper Spaans // Lead Developer www.FoxDetACT.com
> \   (_)/   Fox-IT - For a more secure society!
>  \    X    T: +31-15-2847999
>   \  / \   M: +31-6-41588725
>    \/      KvK Haaglanden 27301624

Re: [PATCH] megaraid_sas: make the log message about rescanning more informative.

[James Bottomley]

On Wed, 2014-01-08 at 12:28 +0000, Saxena, Sumit wrote:
> 
> >-----Original Message-----
> >From: Jasper Spaans [mailto:spaans@fox-it.com]
> >Sent: Friday, October 25, 2013 5:53 PM
> >To: DL-MegaRAID Linux
> >Cc: linux-scsi@vger.kernel.org
> >Subject: [PATCH] megaraid_sas: make the log message about rescanning
> >more informative.
> >
> >Hi,
> >
> >I was working on one of our servers, and saw the following interesting
> >message in dmesg:
> >
> >[20961024.720972] scanning ...
> >
> >This scared me somewhat. Please find a patch to make it easier to see where
> >this message is coming from.
> >
> >Cheers,
> >Jasper
> >
> >---
> > drivers/scsi/megaraid/megaraid_sas_base.c |    2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
> >b/drivers/scsi/megaraid/megaraid_sas_base.c
> >index 1f0ca68..3457289 100644
> >--- a/drivers/scsi/megaraid/megaraid_sas_base.c
> >+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> >@@ -5461,7 +5461,7 @@ megasas_aen_polling(struct work_struct *work)
> > 	}
> >
> > 	if (doscan) {
> >-		printk(KERN_INFO "scanning ...\n");
> >+		printk(KERN_INFO "Rescanning MegaRAID devices ...\n");
> > 		megasas_get_pd_list(instance);
> > 		for (i = 0; i < MEGASAS_MAX_PD_CHANNELS; i++) {
> > 			for (j = 0; j < MEGASAS_MAX_DEV_PER_CHANNEL;
> >j++) {
> >--
> >1.7.9.5
> Acked-by: Sumit Saxena <sumit.saxena@lsi.com>

I'd prefer consistency for this: Most of the messages in this driver
have a megasas: prefix ... but there are quite a large number that don't
(and which probably should have).  If this is necessary, please use the
standard driver prefix.

Thanks,

James