From: James Bottomley <jbottomley@parallels.com>
To: "hch@infradead.org" <hch@infradead.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"hare@suse.de" <hare@suse.de>
Subject: Re: [PATCH] aic94xx: Fixup compilation warning
Date: Mon, 24 Nov 2014 15:39:21 +0000 [thread overview]
Message-ID: <1416843568.2194.3.camel@parallels.com> (raw)
In-Reply-To: <20141124134014.GA22128@infradead.org>
On Mon, 2014-11-24 at 05:40 -0800, Christoph Hellwig wrote:
> Can someone review this trivial patch for me? Thanks!
I don't really think we need reviewers for trivial patches, do we?
However, the patch is clearly bogus. What's supposed to happen is that
the unset variables (size and offs) get initialised to default values on
error return, which is what's missing for offset, so this is the correct
patch, isn't it?
James
---
diff --git a/drivers/scsi/aic94xx/aic94xx_sds.c b/drivers/scsi/aic94xx/aic94xx_sds.c
index edb43fd..d11b4d7 100644
--- a/drivers/scsi/aic94xx/aic94xx_sds.c
+++ b/drivers/scsi/aic94xx/aic94xx_sds.c
@@ -1003,6 +1003,7 @@ static int asd_process_ctrl_a_user(struct asd_ha_struct *asd_ha,
}
size = sizeof(struct asd_ctrla_phy_settings);
+ offs = 0;
ps = &dflt_ps;
}
next prev parent reply other threads:[~2014-11-24 15:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 7:10 [PATCH] aic94xx: Fixup compilation warning Hannes Reinecke
2014-11-06 6:37 ` Christoph Hellwig
2014-11-24 13:40 ` Christoph Hellwig
2014-11-24 15:39 ` James Bottomley [this message]
2014-11-24 15:55 ` Hannes Reinecke
2014-11-24 16:04 ` Tomas Henzl
2014-11-24 16:10 ` James Bottomley
2014-11-24 16:34 ` Tomas Henzl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416843568.2194.3.camel@parallels.com \
--to=jbottomley@parallels.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox