Re: [PATCH] aic94xx: Fixup compilation warning

[Hannes Reinecke <hare@suse.de>]

On 11/24/2014 04:39 PM, James Bottomley wrote:
> On Mon, 2014-11-24 at 05:40 -0800, Christoph Hellwig wrote:
>> Can someone review this trivial patch for me?  Thanks!
> 
> I don't really think we need reviewers for trivial patches, do we?
> 
> However, the patch is clearly bogus. What's supposed to happen is that
> the unset variables (size and offs) get initialised to default values on
> error return, which is what's missing for offset, so this is the correct
> patch, isn't it?
> 
> James
> 
> ---
> diff --git a/drivers/scsi/aic94xx/aic94xx_sds.c b/drivers/scsi/aic94xx/aic94xx_sds.c
> index edb43fd..d11b4d7 100644
> --- a/drivers/scsi/aic94xx/aic94xx_sds.c
> +++ b/drivers/scsi/aic94xx/aic94xx_sds.c
> @@ -1003,6 +1003,7 @@ static int asd_process_ctrl_a_user(struct asd_ha_struct *asd_ha,
>  		}
>  
>  		size = sizeof(struct asd_ctrla_phy_settings);
> +		offs = 0;
>  		ps = &dflt_ps;
>  	}
>  
> 
Yep, that would work, as well.

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html