* [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag
@ 2015-08-31 15:21 K. Y. Srinivasan
2015-08-31 14:01 ` James Bottomley
0 siblings, 1 reply; 4+ messages in thread
From: K. Y. Srinivasan @ 2015-08-31 15:21 UTC (permalink / raw)
To: gregkh, linux-kernel, devel, ohering, jbottomley, hch, linux-scsi,
apw, vkuznets, jasowang
Cc: stable
Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not specifying
tags.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Cc: stable@vger.kernel.org
---
drivers/scsi/storvsc_drv.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 40c43ae..ad8c4bc 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -1647,8 +1647,7 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
vm_srb->win8_extension.time_out_value = 60;
vm_srb->win8_extension.srb_flags |=
- (SRB_FLAGS_QUEUE_ACTION_ENABLE |
- SRB_FLAGS_DISABLE_SYNCH_TRANSFER);
+ SRB_FLAGS_DISABLE_SYNCH_TRANSFER;
/* Build the SRB */
switch (scmnd->sc_data_direction) {
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag
2015-08-31 15:21 [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag K. Y. Srinivasan
@ 2015-08-31 14:01 ` James Bottomley
2015-08-31 14:09 ` KY Srinivasan
2015-10-06 0:03 ` KY Srinivasan
0 siblings, 2 replies; 4+ messages in thread
From: James Bottomley @ 2015-08-31 14:01 UTC (permalink / raw)
To: K. Y. Srinivasan
Cc: linux-scsi, gregkh, jasowang, ohering, jbottomley, linux-kernel,
hch, stable, apw, devel
On Mon, 2015-08-31 at 08:21 -0700, K. Y. Srinivasan wrote:
> Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not specifying
> tags.
What's the actual problem description this causes?
James
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/scsi/storvsc_drv.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 40c43ae..ad8c4bc 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1647,8 +1647,7 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
> vm_srb->win8_extension.time_out_value = 60;
>
> vm_srb->win8_extension.srb_flags |=
> - (SRB_FLAGS_QUEUE_ACTION_ENABLE |
> - SRB_FLAGS_DISABLE_SYNCH_TRANSFER);
> + SRB_FLAGS_DISABLE_SYNCH_TRANSFER;
>
> /* Build the SRB */
> switch (scmnd->sc_data_direction) {
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag
2015-08-31 14:01 ` James Bottomley
@ 2015-08-31 14:09 ` KY Srinivasan
2015-10-06 0:03 ` KY Srinivasan
1 sibling, 0 replies; 4+ messages in thread
From: KY Srinivasan @ 2015-08-31 14:09 UTC (permalink / raw)
To: James Bottomley
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, ohering@suse.com,
jbottomley@parallels.com, hch@infradead.org,
linux-scsi@vger.kernel.org, apw@canonical.com,
vkuznets@redhat.com, jasowang@redhat.com, stable@vger.kernel.org
> -----Original Message-----
> From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com]
> Sent: Monday, August 31, 2015 7:02 AM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; ohering@suse.com;
> jbottomley@parallels.com; hch@infradead.org; linux-scsi@vger.kernel.org;
> apw@canonical.com; vkuznets@redhat.com; jasowang@redhat.com;
> stable@vger.kernel.org
> Subject: Re: [PATCH 1/1] storvsc: Don't set the
> SRB_FLAGS_QUEUE_ACTION_ENABLE flag
>
> On Mon, 2015-08-31 at 08:21 -0700, K. Y. Srinivasan wrote:
> > Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not
> specifying
> > tags.
>
> What's the actual problem description this causes?
Qlogic driver does not work correctly if the SRB_FLAGS_QUEUE_ACTION_ENABLE
is set and no action tag is specified.
Regards,
K. Y
>
> James
>
>
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > Cc: stable@vger.kernel.org
> > ---
> > drivers/scsi/storvsc_drv.c | 3 +--
> > 1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> > index 40c43ae..ad8c4bc 100644
> > --- a/drivers/scsi/storvsc_drv.c
> > +++ b/drivers/scsi/storvsc_drv.c
> > @@ -1647,8 +1647,7 @@ static int storvsc_queuecommand(struct
> Scsi_Host *host, struct scsi_cmnd *scmnd)
> > vm_srb->win8_extension.time_out_value = 60;
> >
> > vm_srb->win8_extension.srb_flags |=
> > - (SRB_FLAGS_QUEUE_ACTION_ENABLE |
> > - SRB_FLAGS_DISABLE_SYNCH_TRANSFER);
> > + SRB_FLAGS_DISABLE_SYNCH_TRANSFER;
> >
> > /* Build the SRB */
> > switch (scmnd->sc_data_direction) {
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag
2015-08-31 14:01 ` James Bottomley
2015-08-31 14:09 ` KY Srinivasan
@ 2015-10-06 0:03 ` KY Srinivasan
1 sibling, 0 replies; 4+ messages in thread
From: KY Srinivasan @ 2015-10-06 0:03 UTC (permalink / raw)
To: James Bottomley
Cc: linux-scsi@vger.kernel.org, gregkh@linuxfoundation.org,
jasowang@redhat.com, ohering@suse.com, jbottomley@parallels.com,
linux-kernel@vger.kernel.org, hch@infradead.org,
stable@vger.kernel.org, apw@canonical.com,
devel@linuxdriverproject.org
> -----Original Message-----
> From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com]
> Sent: Monday, August 31, 2015 7:02 AM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; ohering@suse.com;
> jbottomley@parallels.com; hch@infradead.org; linux-scsi@vger.kernel.org;
> apw@canonical.com; vkuznets@redhat.com; jasowang@redhat.com;
> stable@vger.kernel.org
> Subject: Re: [PATCH 1/1] storvsc: Don't set the
> SRB_FLAGS_QUEUE_ACTION_ENABLE flag
>
> On Mon, 2015-08-31 at 08:21 -0700, K. Y. Srinivasan wrote:
> > Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not
> specifying
> > tags.
>
> What's the actual problem description this causes?
James,
Should I resend this patch. I think I provided the clarification you had sought.
Regards,
K. Y
>
> James
>
>
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > Cc: stable@vger.kernel.org
> > ---
> > drivers/scsi/storvsc_drv.c | 3 +--
> > 1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> > index 40c43ae..ad8c4bc 100644
> > --- a/drivers/scsi/storvsc_drv.c
> > +++ b/drivers/scsi/storvsc_drv.c
> > @@ -1647,8 +1647,7 @@ static int storvsc_queuecommand(struct
> Scsi_Host *host, struct scsi_cmnd *scmnd)
> > vm_srb->win8_extension.time_out_value = 60;
> >
> > vm_srb->win8_extension.srb_flags |=
> > - (SRB_FLAGS_QUEUE_ACTION_ENABLE |
> > - SRB_FLAGS_DISABLE_SYNCH_TRANSFER);
> > + SRB_FLAGS_DISABLE_SYNCH_TRANSFER;
> >
> > /* Build the SRB */
> > switch (scmnd->sc_data_direction) {
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-06 0:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-31 15:21 [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag K. Y. Srinivasan
2015-08-31 14:01 ` James Bottomley
2015-08-31 14:09 ` KY Srinivasan
2015-10-06 0:03 ` KY Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox