* [PATCH 0/2] Patches for scsi "misc" branch
@ 2015-08-13 10:41 anil.gurumurthy
2015-08-13 10:41 ` [PATCH 1/2] bfa: Fix indentation anil.gurumurthy
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: anil.gurumurthy @ 2015-08-13 10:41 UTC (permalink / raw)
To: James.Bottomley, hch; +Cc: linux-scsi, sudarsana.kalluru, Anil Gurumurthy
From: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
Hi James, Christoph,
Please apply the following patches to the scsi tree, misc branch at your
earliest convenience.
Thanks,
Anil
Anil Gurumurthy (2):
bfa: Fix indentation
bfa: Fix incorrect de-reference of pointer
drivers/scsi/bfa/bfa_ioc.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
--
1.7.10.4
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] bfa: Fix indentation
2015-08-13 10:41 [PATCH 0/2] Patches for scsi "misc" branch anil.gurumurthy
@ 2015-08-13 10:41 ` anil.gurumurthy
2015-09-03 14:31 ` Ewan Milne
2015-08-13 10:41 ` [PATCH 2/2] bfa: Fix incorrect de-reference of pointer anil.gurumurthy
2015-08-28 19:09 ` [PATCH 0/2] Patches for scsi "misc" branch James Bottomley
2 siblings, 1 reply; 6+ messages in thread
From: anil.gurumurthy @ 2015-08-13 10:41 UTC (permalink / raw)
To: James.Bottomley, hch; +Cc: linux-scsi, sudarsana.kalluru, Anil Gurumurthy
From: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
Signed-off-by: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
Tested-by : Sudarasana Kalluru <sudarsana.kalluru@qlogic.com>
---
drivers/scsi/bfa/bfa_ioc.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c
index 315d6d6..4e71044 100644
--- a/drivers/scsi/bfa/bfa_ioc.c
+++ b/drivers/scsi/bfa/bfa_ioc.c
@@ -3665,19 +3665,19 @@ bfa_cb_sfp_state_query(struct bfa_sfp_s *sfp)
if (sfp->state_query_cbfn)
sfp->state_query_cbfn(sfp->state_query_cbarg,
sfp->status);
- sfp->media = NULL;
- }
+ sfp->media = NULL;
+ }
- if (sfp->portspeed) {
- sfp->status = bfa_sfp_speed_valid(sfp, sfp->portspeed);
- if (sfp->state_query_cbfn)
- sfp->state_query_cbfn(sfp->state_query_cbarg,
- sfp->status);
- sfp->portspeed = BFA_PORT_SPEED_UNKNOWN;
- }
+ if (sfp->portspeed) {
+ sfp->status = bfa_sfp_speed_valid(sfp, sfp->portspeed);
+ if (sfp->state_query_cbfn)
+ sfp->state_query_cbfn(sfp->state_query_cbarg,
+ sfp->status);
+ sfp->portspeed = BFA_PORT_SPEED_UNKNOWN;
+ }
- sfp->state_query_lock = 0;
- sfp->state_query_cbfn = NULL;
+ sfp->state_query_lock = 0;
+ sfp->state_query_cbfn = NULL;
}
/*
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] bfa: Fix indentation
2015-08-13 10:41 ` [PATCH 1/2] bfa: Fix indentation anil.gurumurthy
@ 2015-09-03 14:31 ` Ewan Milne
0 siblings, 0 replies; 6+ messages in thread
From: Ewan Milne @ 2015-09-03 14:31 UTC (permalink / raw)
To: anil.gurumurthy; +Cc: James.Bottomley, hch, linux-scsi, sudarsana.kalluru
On Thu, 2015-08-13 at 06:41 -0400, anil.gurumurthy@qlogic.com wrote:
> From: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
>
> Signed-off-by: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
> Tested-by : Sudarasana Kalluru <sudarsana.kalluru@qlogic.com>
> ---
> drivers/scsi/bfa/bfa_ioc.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c
> index 315d6d6..4e71044 100644
> --- a/drivers/scsi/bfa/bfa_ioc.c
> +++ b/drivers/scsi/bfa/bfa_ioc.c
> @@ -3665,19 +3665,19 @@ bfa_cb_sfp_state_query(struct bfa_sfp_s *sfp)
> if (sfp->state_query_cbfn)
> sfp->state_query_cbfn(sfp->state_query_cbarg,
> sfp->status);
> - sfp->media = NULL;
> - }
> + sfp->media = NULL;
> + }
>
> - if (sfp->portspeed) {
> - sfp->status = bfa_sfp_speed_valid(sfp, sfp->portspeed);
> - if (sfp->state_query_cbfn)
> - sfp->state_query_cbfn(sfp->state_query_cbarg,
> - sfp->status);
> - sfp->portspeed = BFA_PORT_SPEED_UNKNOWN;
> - }
> + if (sfp->portspeed) {
> + sfp->status = bfa_sfp_speed_valid(sfp, sfp->portspeed);
> + if (sfp->state_query_cbfn)
> + sfp->state_query_cbfn(sfp->state_query_cbarg,
> + sfp->status);
> + sfp->portspeed = BFA_PORT_SPEED_UNKNOWN;
> + }
>
> - sfp->state_query_lock = 0;
> - sfp->state_query_cbfn = NULL;
> + sfp->state_query_lock = 0;
> + sfp->state_query_cbfn = NULL;
> }
>
> /*
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] bfa: Fix incorrect de-reference of pointer
2015-08-13 10:41 [PATCH 0/2] Patches for scsi "misc" branch anil.gurumurthy
2015-08-13 10:41 ` [PATCH 1/2] bfa: Fix indentation anil.gurumurthy
@ 2015-08-13 10:41 ` anil.gurumurthy
2015-09-03 14:32 ` Ewan Milne
2015-08-28 19:09 ` [PATCH 0/2] Patches for scsi "misc" branch James Bottomley
2 siblings, 1 reply; 6+ messages in thread
From: anil.gurumurthy @ 2015-08-13 10:41 UTC (permalink / raw)
To: James.Bottomley, hch; +Cc: linux-scsi, sudarsana.kalluru, Anil Gurumurthy
From: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
Signed-off-by: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
Tested-by: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
---
drivers/scsi/bfa/bfa_ioc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c
index 4e71044..98f7e8c 100644
--- a/drivers/scsi/bfa/bfa_ioc.c
+++ b/drivers/scsi/bfa/bfa_ioc.c
@@ -3878,7 +3878,7 @@ bfa_sfp_show_comp(struct bfa_sfp_s *sfp, struct bfi_mbmsg_s *msg)
bfa_trc(sfp, sfp->data_valid);
if (sfp->data_valid) {
u32 size = sizeof(struct sfp_mem_s);
- u8 *des = (u8 *) &(sfp->sfpmem);
+ u8 *des = (u8 *)(sfp->sfpmem);
memcpy(des, sfp->dbuf_kva, size);
}
/*
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] bfa: Fix incorrect de-reference of pointer
2015-08-13 10:41 ` [PATCH 2/2] bfa: Fix incorrect de-reference of pointer anil.gurumurthy
@ 2015-09-03 14:32 ` Ewan Milne
0 siblings, 0 replies; 6+ messages in thread
From: Ewan Milne @ 2015-09-03 14:32 UTC (permalink / raw)
To: anil.gurumurthy; +Cc: James.Bottomley, hch, linux-scsi, sudarsana.kalluru
On Thu, 2015-08-13 at 06:41 -0400, anil.gurumurthy@qlogic.com wrote:
> From: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
>
> Signed-off-by: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
> Tested-by: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
> ---
> drivers/scsi/bfa/bfa_ioc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c
> index 4e71044..98f7e8c 100644
> --- a/drivers/scsi/bfa/bfa_ioc.c
> +++ b/drivers/scsi/bfa/bfa_ioc.c
> @@ -3878,7 +3878,7 @@ bfa_sfp_show_comp(struct bfa_sfp_s *sfp, struct bfi_mbmsg_s *msg)
> bfa_trc(sfp, sfp->data_valid);
> if (sfp->data_valid) {
> u32 size = sizeof(struct sfp_mem_s);
> - u8 *des = (u8 *) &(sfp->sfpmem);
> + u8 *des = (u8 *)(sfp->sfpmem);
> memcpy(des, sfp->dbuf_kva, size);
> }
> /*
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Patches for scsi "misc" branch
2015-08-13 10:41 [PATCH 0/2] Patches for scsi "misc" branch anil.gurumurthy
2015-08-13 10:41 ` [PATCH 1/2] bfa: Fix indentation anil.gurumurthy
2015-08-13 10:41 ` [PATCH 2/2] bfa: Fix incorrect de-reference of pointer anil.gurumurthy
@ 2015-08-28 19:09 ` James Bottomley
2 siblings, 0 replies; 6+ messages in thread
From: James Bottomley @ 2015-08-28 19:09 UTC (permalink / raw)
To: anil.gurumurthy; +Cc: hch, linux-scsi, sudarsana.kalluru
On Thu, 2015-08-13 at 06:41 -0400, anil.gurumurthy@qlogic.com wrote:
> From: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
>
> Hi James, Christoph,
>
> Please apply the following patches to the scsi tree, misc branch at your
> earliest convenience.
Both of these patches look OK to me. Could I get a second review,
please?
James
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-03 14:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-13 10:41 [PATCH 0/2] Patches for scsi "misc" branch anil.gurumurthy
2015-08-13 10:41 ` [PATCH 1/2] bfa: Fix indentation anil.gurumurthy
2015-09-03 14:31 ` Ewan Milne
2015-08-13 10:41 ` [PATCH 2/2] bfa: Fix incorrect de-reference of pointer anil.gurumurthy
2015-09-03 14:32 ` Ewan Milne
2015-08-28 19:09 ` [PATCH 0/2] Patches for scsi "misc" branch James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox