From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Bart Van Assche <bart.vanassche@sandisk.com>,
Christoph Hellwig <hch@lst.de>,
Johannes Thumshirn <jthumshirn@suse.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 2/2] Restart list search after unlock in scsi_remove_target
Date: Thu, 05 Nov 2015 09:05:47 -0800 [thread overview]
Message-ID: <1446743147.2211.19.camel@HansenPartnership.com> (raw)
In-Reply-To: <CAPcyv4iO0iX2_DCSKz8aXSqeu22bO=kq9CtRtH-MSrKm4ouxfg@mail.gmail.com>
On Thu, 2015-11-05 at 08:55 -0800, Dan Williams wrote:
> On Wed, Nov 4, 2015 at 2:44 PM, James Bottomley
> <James.Bottomley@hansenpartnership.com> wrote:
> [..]
> > The fundamental problem with this is how have the conditions that caused
> > us to move away from list restart:
> >
> > commit bc3f02a795d3b4faa99d37390174be2a75d091bd
> > Author: Dan Williams <djbw@fb.com>
> > Date: Tue Aug 28 22:12:10 2012 -0700
> >
> > [SCSI] scsi_remove_target: fix softlockup regression on hot remove
> >
> > Which was triggered by this bug report
> >
> > http://thread.gmane.org/gmane.linux.kernel/1348679
> >
> > been mitigated?
> >
>
> I think it has because the problem that led to that report was the
> fact that scsi_target_destroy() did not advance the target state, but
> we changed that in f2495e228fce.
>
> http://marc.info/?l=linux-scsi&m=144527527308725&w=2
Great, thanks, we'll put Christoph's version in then, because it can be
cc'd to stable without problems. Bart, you can redo your state updates
on top of this because that's inessential to the current problem.
James
next prev parent reply other threads:[~2015-11-05 17:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 22:06 [PATCH 0/2] Fix a hard lockup in scsi_remove_target() Bart Van Assche
2015-10-30 22:08 ` [PATCH 1/2] Separate target visibility from reaped state information Bart Van Assche
2015-11-05 8:50 ` Christoph Hellwig
2015-10-30 22:09 ` [PATCH 2/2] Restart list search after unlock in scsi_remove_target Bart Van Assche
2015-11-04 22:35 ` Bart Van Assche
2015-11-04 22:44 ` James Bottomley
2015-11-04 23:20 ` Bart Van Assche
2015-11-16 17:57 ` Christoph Hellwig
2015-11-05 16:55 ` Dan Williams
2015-11-05 17:05 ` James Bottomley [this message]
2015-11-05 8:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446743147.2211.19.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=bart.vanassche@sandisk.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox