public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: James Bottomley <jbottomley@parallels.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
	Christoph Hellwig <hch@lst.de>,
	Dan Williams <dan.j.williams@intel.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: [PATCH 0/2] Fix a hard lockup in scsi_remove_target()
Date: Fri, 30 Oct 2015 15:06:42 -0700	[thread overview]
Message-ID: <5633E9F2.5080209@sandisk.com> (raw)

On October 2, 2015 Johannes Thumshirn reported the following hard lockup 
(see also http://thread.gmane.org/gmane.linux.kernel/2052359):

Kernel panic - not syncing: Watchdog detected hard LOCKUP on cpu 0
[...]
Call Trace:
  [<ffffffff8100471d>] dump_trace+0x7d/0x2d0
  [<ffffffff81004a04>] show_stack_log_lvl+0x94/0x170
  [<ffffffff81005cc1>] show_stack+0x21/0x50
  [<ffffffff8151aa75>] dump_stack+0x41/0x51
  [<ffffffff8151545a>] panic+0xc8/0x1d7
  [<ffffffff810fbdda>] watchdog_overflow_callback+0xba/0xc0
  [<ffffffff811336c8>] __perf_event_overflow+0x88/0x240
  [<ffffffff8101e3aa>] intel_pmu_handle_irq+0x1fa/0x3e0
  [<ffffffff81522836>] perf_event_nmi_handler+0x26/0x40
  [<ffffffff81521fcd>] nmi_handle.isra.2+0x8d/0x180
  [<ffffffff815221e6>] do_nmi+0x126/0x3c0
  [<ffffffff8152159b>] end_repeat_nmi+0x1a/0x1e
  [<ffffffffa00212e8>] scsi_remove_target+0x68/0x240 [scsi_mod]
  [<ffffffff81072742>] process_one_work+0x172/0x420
  [<ffffffff810733ba>] worker_thread+0x11a/0x3c0
  [<ffffffff81079d34>] kthread+0xb4/0xc0
  [<ffffffff81528cd8>] ret_from_fork+0x58/0x90

The following two patches fix this lockup:
0001-Separate-target-visibility-from-reaped-state-informa.patch
0002-Restart-list-search-after-unlock-in-scsi_remove_targ.patch

These patches have been tested with the SRP initiator (ib_srp).

             reply	other threads:[~2015-10-30 22:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-30 22:06 Bart Van Assche [this message]
2015-10-30 22:08 ` [PATCH 1/2] Separate target visibility from reaped state information Bart Van Assche
2015-11-05  8:50   ` Christoph Hellwig
2015-10-30 22:09 ` [PATCH 2/2] Restart list search after unlock in scsi_remove_target Bart Van Assche
2015-11-04 22:35   ` Bart Van Assche
2015-11-04 22:44     ` James Bottomley
2015-11-04 23:20       ` Bart Van Assche
2015-11-16 17:57         ` Christoph Hellwig
2015-11-05 16:55       ` Dan Williams
2015-11-05 17:05         ` James Bottomley
2015-11-05  8:51     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5633E9F2.5080209@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=dan.j.williams@intel.com \
    --cc=hch@lst.de \
    --cc=jbottomley@parallels.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox