From: "Ewan D. Milne" <emilne@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH 1/3] scsi-trace: remove service action definitions
Date: Thu, 24 Mar 2016 09:03:24 -0400 [thread overview]
Message-ID: <1458824604.17965.69.camel@localhost.localdomain> (raw)
In-Reply-To: <1458815011-9054-2-git-send-email-hare@suse.de>
On Thu, 2016-03-24 at 11:23 +0100, Hannes Reinecke wrote:
> scsi_opcode_name() is displaying the opcode, not the service
> action.
>
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> ---
> include/trace/events/scsi.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/include/trace/events/scsi.h b/include/trace/events/scsi.h
> index 079bd10..5c0d91f 100644
> --- a/include/trace/events/scsi.h
> +++ b/include/trace/events/scsi.h
> @@ -95,10 +95,6 @@
> scsi_opcode_name(VERIFY_16), \
> scsi_opcode_name(WRITE_SAME_16), \
> scsi_opcode_name(SERVICE_ACTION_IN_16), \
> - scsi_opcode_name(SAI_READ_CAPACITY_16), \
> - scsi_opcode_name(SAI_GET_LBA_STATUS), \
> - scsi_opcode_name(MI_REPORT_TARGET_PGS), \
> - scsi_opcode_name(MO_SET_TARGET_PGS), \
> scsi_opcode_name(READ_32), \
> scsi_opcode_name(WRITE_32), \
> scsi_opcode_name(WRITE_SAME_32), \
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
next prev parent reply other threads:[~2016-03-24 13:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 10:23 [PATCH 0/3] scsi trace updates Hannes Reinecke
2016-03-24 10:23 ` [PATCH 1/3] scsi-trace: remove service action definitions Hannes Reinecke
2016-03-24 13:03 ` Ewan D. Milne [this message]
2016-03-24 10:23 ` [PATCH 2/3] scsi-trace: Decode MAINTENANCE_IN and MAINTENANCE_OUT commands Hannes Reinecke
2016-03-24 13:03 ` Ewan D. Milne
2016-03-24 10:23 ` [PATCH 3/3] scsi-trace: define ZBC_IN and ZBC_OUT Hannes Reinecke
2016-03-24 13:40 ` Ewan D. Milne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458824604.17965.69.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox