RE: [PATCH 1/4] scsi: ufs: Return in case of an invalid tag

[Daejun Park <daejun7.park@samsung.com>]

Hi Bart,

> If a tag is invalid, instead of only issuing a kernel warning, also
> return. This patch suppresses Coverity warnings about left shifts with a
> negative right hand operand.
> 
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
>  drivers/ufs/core/ufshcd.c | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index dc1285351336..5fccec3c1091 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -2822,7 +2822,8 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd)
>          int err = 0;
>          struct ufs_hw_queue *hwq = NULL;
>  
> -        WARN_ONCE(tag < 0 || tag >= hba->nutrs, "Invalid tag %d\n", tag);
> +        if (WARN_ONCE(tag < 0 || tag >= hba->nutrs, "Invalid tag %d\n", tag))
> +                return 0;

As far as I know, a return 0 from a queuecommand means that the request was accepted by LLD. 

Thanks,
Daejun