From: James Bottomley <jejb@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
Parisc List <linux-parisc@vger.kernel.org>
Subject: Re: [PATCH] 53c700: fix BUG on untagged commands
Date: Tue, 14 Jun 2016 20:31:51 -0700 [thread overview]
Message-ID: <1465961511.2273.107.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160614150555.GA698@infradead.org>
On Tue, 2016-06-14 at 08:05 -0700, Christoph Hellwig wrote:
> Looks fine:
>
> Acked-by: Christoph Hellwig <hch@lst.de>
>
> But it should really go together with something like this:
Well, we need the simplest fix to backport, which is why I sent what I
did.
> ---
> From e54d1462ae244db3189a8b69018bc5f3e3d3b468 Mon Sep 17 00:00:00
> 2001
> From: Christoph Hellwig <hch@lst.de>
> Date: Tue, 14 Jun 2016 17:04:10 +0200
> Subject: scsi: move current_cmnd into the 53c700 driver
>
> The 53c700 driver is the only user of the current_cmnd field in
> struct scsi_device, so let's move it into the driver private data.
The style in the driver is to use accessor functions for device
parameters, but I don't see it matters much since the day anyone would
write a new SPI driver (for which this was often the template) is long
gone.
James
next prev parent reply other threads:[~2016-06-15 3:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 5:00 [PATCH] 53c700: fix BUG on untagged commands James Bottomley
2016-06-14 7:15 ` Johannes Thumshirn
2016-06-14 13:10 ` Ewan D. Milne
2016-06-14 15:05 ` Christoph Hellwig
2016-06-14 20:32 ` Helge Deller
2016-06-15 2:03 ` Martin K. Petersen
2016-06-15 3:31 ` James Bottomley [this message]
2016-06-15 6:41 ` Hannes Reinecke
2016-06-15 2:00 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465961511.2273.107.camel@linux.vnet.ibm.com \
--to=jejb@linux.vnet.ibm.com \
--cc=hch@infradead.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox