From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: James Bottomley <jejb@linux.vnet.ibm.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
Parisc List <linux-parisc@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] 53c700: fix BUG on untagged commands
Date: Tue, 14 Jun 2016 22:00:59 -0400 [thread overview]
Message-ID: <yq1shwfb484.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1465880407.18583.18.camel@linux.vnet.ibm.com> (James Bottomley's message of "Mon, 13 Jun 2016 22:00:07 -0700")
>>>>> "James" == James Bottomley <jejb@linux.vnet.ibm.com> writes:
James> The untagged command case in the 53c700 driver has been broken
James> since host wide tags were enabled because the replaced
James> scsi_find_tag() function had a special case for the tag value
James> SCSI_NO_TAG to retrieve sdev-> current_cmnd. The replacement
James> function scsi_host_find_tag() has no such special case and
James> returns NULL causing untagged commands to trigger a BUG() in the
James> driver. Inspection shows that the 53c700 is the only driver
James> using this SCSI_NO_TAG case, so a local fix in the driver
James> suffices to fix this problem globally.
Applied to 4.7/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2016-06-15 2:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 5:00 [PATCH] 53c700: fix BUG on untagged commands James Bottomley
2016-06-14 7:15 ` Johannes Thumshirn
2016-06-14 13:10 ` Ewan D. Milne
2016-06-14 15:05 ` Christoph Hellwig
2016-06-14 20:32 ` Helge Deller
2016-06-15 2:03 ` Martin K. Petersen
2016-06-15 3:31 ` James Bottomley
2016-06-15 6:41 ` Hannes Reinecke
2016-06-15 2:00 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1shwfb484.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox