public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
	"yanaijie@huawei.com" <yanaijie@huawei.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"jthumshirn@suse.de" <jthumshirn@suse.de>,
	Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: [PATCH] scsi: remove extra white space at the end of the line
Date: Thu, 21 Dec 2017 16:09:07 +0000	[thread overview]
Message-ID: <1513872544.2931.13.camel@wdc.com> (raw)
In-Reply-To: <20171221024049.36509-1-yanaijie@huawei.com>

On Thu, 2017-12-21 at 10:40 +0800, Jason Yan wrote:
> My editor always try to remove the extra white space at the end of the
> line when I make some changes. I'm tired of adjusting them manually.
> Can we remove them in mainline?

Hello Jason,

I think this means that your editor has been misconfigured. Any kernel code
changes should be the result of a deliberate action by a human. Configuring an
editor to apply any changes automatically to existing code is wrong.

There are several reasons why most kernel maintainers ignore patches like this
one silently:
* Whitespace changes make it harder than necessary to backport patches to
  distro kernels. Before a patch that came later than the whitespace changes
  can be backported, the whitespace change has to be backported. Additionally,
  if a whitespace change touches many source files, the order in which to
  backport patches becomes really important.
* Before a kernel developer posts a patch that fixes a bug she or he has to
  verify the change history (git log -p) to figure out which patch introduced
  the bug. Patches that only change coding style pollute the change history.
* Accepting a patch that only changes whitespace would open the floodgates for
  other kernel coding style change patches. If a patch that only changes
  whitespace would get accepted it will become hard to keep other kernel
  coding style change patches out. A few examples of recently posted coding
  style patches that do not change any functionality are:
  - scsi_dh: fix format of struct members
    (https://marc.info/?l=linux-scsi&m=151344115716122&w=2).
  - PS3: Adjustments for six function implementations
    (https://www.spinics.net/lists/linux-kernel-janitors/msg38252.html).

See also https://btrfs.wiki.kernel.org/index.php/Developer%27s_FAQ#How_not_to_start.

Thanks,

Bart.

  parent reply	other threads:[~2017-12-21 16:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21  2:40 [PATCH] scsi: remove extra white space at the end of the line Jason Yan
2017-12-21  5:41 ` Damien Le Moal
2017-12-21  8:48   ` Johannes Thumshirn
2017-12-21 16:09 ` Bart Van Assche [this message]
2017-12-22  1:37   ` Jason Yan
2017-12-22  7:03   ` Johannes Thumshirn
2018-01-04  3:36     ` Martin K. Petersen
2018-01-08  8:21       ` Johannes Thumshirn
2017-12-24  1:10   ` Finn Thain
  -- strict thread matches above, loose matches on Subject: below --
2018-01-22 23:41 Xose Vazquez Perez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513872544.2931.13.camel@wdc.com \
    --to=bart.vanassche@wdc.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=yanaijie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox