public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: Jason Yan <yanaijie@huawei.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] scsi: remove extra white space at the end of the line
Date: Thu, 21 Dec 2017 09:48:09 +0100	[thread overview]
Message-ID: <20171221084809.jopfma3hsjez4s33@linux-x5ow.site> (raw)
In-Reply-To: <c8a634e9-22b8-ac99-e0db-05b1566ed2e9@wdc.com>

On Thu, Dec 21, 2017 at 05:41:00AM +0000, Damien Le Moal wrote:
> Jason,
> 
> On 12/21/17 11:40, Jason Yan wrote:
> > My editor always try to remove the extra white space at the end of the
> > line when I make some changes. I'm tired of adjusting them manually.
> > Can we remove them in mainline?
> > 
> > Signed-off-by: Jason Yan <yanaijie@huawei.com>
> > ---
> >  drivers/scsi/scsi.c       |  2 +-
> >  drivers/scsi/scsi_lib.c   | 20 ++++++++++----------
> >  drivers/scsi/scsi_scan.c  | 10 +++++-----
> >  drivers/scsi/scsi_sysfs.c |  4 ++--
> >  4 files changed, 18 insertions(+), 18 deletions(-)
> 
> There are plenty in drivers/scsi/sd.c too :)
> I would also love to get rid of these white spaces so that my emacs
> stops looking like a Christmas tree all year long.
> Last time I tried I got nacked...
> 
> Martin,
> 
> What about a (may be big) whitespace-only patch to clean up all the scsi
> code and finally get checkpatch to stop screaming at us if we touch a
> line near one with whitespaces (which can happen a lot...) ?

+1 

Please let's get rid of this whitespace mess.

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

  reply	other threads:[~2017-12-21  8:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21  2:40 [PATCH] scsi: remove extra white space at the end of the line Jason Yan
2017-12-21  5:41 ` Damien Le Moal
2017-12-21  8:48   ` Johannes Thumshirn [this message]
2017-12-21 16:09 ` Bart Van Assche
2017-12-22  1:37   ` Jason Yan
2017-12-22  7:03   ` Johannes Thumshirn
2018-01-04  3:36     ` Martin K. Petersen
2018-01-08  8:21       ` Johannes Thumshirn
2017-12-24  1:10   ` Finn Thain
  -- strict thread matches above, loose matches on Subject: below --
2018-01-22 23:41 Xose Vazquez Perez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171221084809.jopfma3hsjez4s33@linux-x5ow.site \
    --to=jthumshirn@suse.de \
    --cc=Damien.LeMoal@wdc.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=yanaijie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox