* [PATCH] libiscsi: Sparse fixes
@ 2012-01-14 16:40 Bart Van Assche
2012-01-14 17:20 ` Bart Van Assche
0 siblings, 1 reply; 2+ messages in thread
From: Bart Van Assche @ 2012-01-14 16:40 UTC (permalink / raw)
To: linux-scsi, Mike Christie
Reduce the number of complaints reported by sparse on libiscsi.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Cc: Mike Christie <michaelc@cs.wisc.edu>
---
drivers/scsi/libiscsi.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 3faa45a..143bbe4 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -1762,8 +1762,6 @@ static void iscsi_tmf_timedout(unsigned long data)
static int iscsi_exec_task_mgmt_fn(struct iscsi_conn *conn,
struct iscsi_tm *hdr, int age,
int timeout)
- __releases(&conn->session->lock)
- __acquires(&conn->session->lock)
{
struct iscsi_session *session = conn->session;
struct iscsi_task *task;
@@ -2386,7 +2384,7 @@ static void iscsi_prep_tgt_reset_pdu(struct scsi_cmnd *sc, struct iscsi_tm *hdr)
*
* This will attempt to send a warm target reset.
*/
-static int iscsi_eh_target_reset(struct scsi_cmnd *sc)
+int iscsi_eh_target_reset(struct scsi_cmnd *sc)
{
struct iscsi_cls_session *cls_session;
struct iscsi_session *session;
--
1.7.7
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] libiscsi: Sparse fixes
2012-01-14 16:40 [PATCH] libiscsi: Sparse fixes Bart Van Assche
@ 2012-01-14 17:20 ` Bart Van Assche
0 siblings, 0 replies; 2+ messages in thread
From: Bart Van Assche @ 2012-01-14 17:20 UTC (permalink / raw)
To: linux-scsi; +Cc: Mike Christie
Reduce the number of complaints reported by sparse on libiscsi.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Cc: Mike Christie <michaelc@cs.wisc.edu>
---
Please ignore the previous version of this patch - it was a reverse patch instead of a regular patch.
drivers/scsi/libiscsi.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 143bbe4..3faa45a 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -1762,6 +1762,8 @@ static void iscsi_tmf_timedout(unsigned long data)
static int iscsi_exec_task_mgmt_fn(struct iscsi_conn *conn,
struct iscsi_tm *hdr, int age,
int timeout)
+ __releases(&conn->session->lock)
+ __acquires(&conn->session->lock)
{
struct iscsi_session *session = conn->session;
struct iscsi_task *task;
@@ -2384,7 +2386,7 @@ static void iscsi_prep_tgt_reset_pdu(struct scsi_cmnd *sc, struct iscsi_tm *hdr)
*
* This will attempt to send a warm target reset.
*/
-int iscsi_eh_target_reset(struct scsi_cmnd *sc)
+static int iscsi_eh_target_reset(struct scsi_cmnd *sc)
{
struct iscsi_cls_session *cls_session;
struct iscsi_session *session;
--
1.7.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-14 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-14 16:40 [PATCH] libiscsi: Sparse fixes Bart Van Assche
2012-01-14 17:20 ` Bart Van Assche
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox