From: Can Guo <cang@qti.qualcomm.com>
To: quic_cang@quicinc.com, bvanassche@acm.org, mani@kernel.org,
stanley.chu@mediatek.com, adrian.hunter@intel.com,
beanhuo@micron.com, avri.altman@wdc.com,
junwoo80.lee@samsung.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM SUPPORT),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v2 4/7] scsi: ufs: ufs-qcom: Limit HS-G5 Rate-A to hosts with HW version 5
Date: Mon, 6 Nov 2023 20:46:10 -0800 [thread overview]
Message-ID: <1699332374-9324-5-git-send-email-cang@qti.qualcomm.com> (raw)
In-Reply-To: <1699332374-9324-1-git-send-email-cang@qti.qualcomm.com>
From: Can Guo <quic_cang@quicinc.com>
Qcom UFS hosts, with HW ver 5, can only support up to HS-G5 Rate-A due to
HW limitations. If the HS-G5 PHY gear is used, update host_params->hs_rate
to Rate-A, so that the subsequent power mode changes shall stick to Rate-A.
Signed-off-by: Can Guo <quic_cang@quicinc.com>
---
drivers/ufs/host/ufs-qcom.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 60b35ca..55ee31d 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -442,9 +442,25 @@ static u32 ufs_qcom_get_hs_gear(struct ufs_hba *hba)
static int ufs_qcom_power_up_sequence(struct ufs_hba *hba)
{
struct ufs_qcom_host *host = ufshcd_get_variant(hba);
+ struct ufs_host_params *host_params = &host->host_params;
struct phy *phy = host->generic_phy;
+ enum phy_mode mode;
int ret;
+ /*
+ * HW ver 5 can only support up to HS-G5 Rate-A due to HW limitations.
+ * If the HS-G5 PHY gear is used, update host_params->hs_rate to Rate-A,
+ * so that the subsequent power mode change shall stick to Rate-A.
+ */
+ if (host->hw_ver.major == 0x5) {
+ if (host->phy_gear == UFS_HS_G5)
+ host_params->hs_rate = PA_HS_MODE_A;
+ else
+ host_params->hs_rate = PA_HS_MODE_B;
+ }
+
+ mode = host_params->hs_rate == PA_HS_MODE_B ? PHY_MODE_UFS_HS_B : PHY_MODE_UFS_HS_A;
+
/* Reset UFS Host Controller and PHY */
ret = ufs_qcom_host_reset(hba);
if (ret)
@@ -459,7 +475,7 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba)
return ret;
}
- phy_set_mode_ext(phy, PHY_MODE_UFS_HS_B, host->phy_gear);
+ phy_set_mode_ext(phy, mode, host->phy_gear);
/* power on phy - start serdes and phy's power and clocks */
ret = phy_power_on(phy);
--
2.7.4
next prev parent reply other threads:[~2023-11-07 4:47 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 4:46 [PATCH v2 0/7] Enable HS-G5 support on SM8550 Can Guo
2023-11-07 4:46 ` [PATCH v2 1/7] scsi: ufs: host: Rename structure ufs_dev_params to ufs_host_params Can Guo
2023-11-07 19:36 ` Andrew Halaney
2023-11-08 7:44 ` Can Guo
2023-11-07 20:56 ` Bart Van Assche
2023-11-08 7:48 ` Can Guo
2023-11-07 4:46 ` [PATCH v2 2/7] scsi: ufs: ufs-qcom: Setup host power mode during init Can Guo
2023-11-07 20:14 ` Andrew Halaney
2023-11-08 7:47 ` Can Guo
2023-11-08 5:07 ` Manivannan Sadhasivam
2023-11-08 8:07 ` Can Guo
2023-11-07 4:46 ` [PATCH v2 3/7] scsi: ufs: ufs-qcom: Allow the first init start with the maximum supported gear Can Guo
2023-11-08 5:23 ` Manivannan Sadhasivam
2023-11-08 8:21 ` Can Guo
2023-11-08 8:23 ` Can Guo
2023-11-09 3:47 ` Manivannan Sadhasivam
2023-11-09 4:07 ` Can Guo
2023-11-09 7:47 ` Manivannan Sadhasivam
2023-11-07 4:46 ` Can Guo [this message]
2023-11-08 5:25 ` [PATCH v2 4/7] scsi: ufs: ufs-qcom: Limit HS-G5 Rate-A to hosts with HW version 5 Manivannan Sadhasivam
2023-11-08 8:42 ` Can Guo
2023-11-09 3:27 ` Manivannan Sadhasivam
2023-11-07 4:46 ` [PATCH v2 5/7] scsi: ufs: ufs-qcom: Set initial PHY gear to max HS gear for HW ver 5 and newer Can Guo
2023-11-08 5:34 ` Manivannan Sadhasivam
2023-11-08 8:46 ` Can Guo
2023-11-07 4:46 ` [PATCH v2 6/7] phy: qualcomm: phy-qcom-qmp-ufs: Add High Speed Gear 5 support for SM8550 Can Guo
2023-11-07 13:18 ` Dmitry Baryshkov
2023-11-08 5:49 ` Manivannan Sadhasivam
2023-11-08 6:56 ` Dmitry Baryshkov
2023-11-09 3:24 ` Manivannan Sadhasivam
2023-11-09 9:40 ` Dmitry Baryshkov
2023-11-09 10:42 ` Manivannan Sadhasivam
2023-11-09 11:00 ` Dmitry Baryshkov
2023-11-09 16:04 ` Manivannan Sadhasivam
2023-11-09 22:11 ` Dmitry Baryshkov
2023-11-10 13:18 ` Manivannan Sadhasivam
2023-11-10 14:40 ` Can Guo
2023-11-11 4:12 ` Manivannan Sadhasivam
2023-11-12 5:13 ` Can Guo
2023-11-14 6:12 ` Manivannan Sadhasivam
2023-11-14 9:15 ` Dmitry Baryshkov
2023-11-15 7:51 ` Can Guo
2023-11-08 9:19 ` Can Guo
2023-11-09 3:26 ` Manivannan Sadhasivam
2023-11-08 9:02 ` Can Guo
2023-11-10 8:47 ` neil.armstrong
2023-11-10 9:03 ` Can Guo
2023-11-10 9:17 ` neil.armstrong
2023-11-10 9:32 ` Can Guo
2023-11-10 9:35 ` neil.armstrong
2023-11-07 4:46 ` [PATCH v2 7/7] scsi: ufs: ufs-qcom: Add support for UFS device version detection Can Guo
2023-11-08 5:11 ` [PATCH v2 0/7] Enable HS-G5 support on SM8550 Manivannan Sadhasivam
2023-11-08 8:09 ` Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1699332374-9324-5-git-send-email-cang@qti.qualcomm.com \
--to=cang@qti.qualcomm.com \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=junwoo80.lee@samsung.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_cang@quicinc.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox