From: Willem Riede <wrlk@riede.org>
To: linux-scsi@vger.kernel.org
Subject: Re: 2 PATCHES: fix request_tranferlength
Date: Sun, 21 Jul 2002 18:52:33 -0400 [thread overview]
Message-ID: <20020721225233.GG7700@linnie.riede.org> (raw)
In-Reply-To: <20020721151523.D1909@one-eyed-alien.net>; from mdharm-usb@one-eyed-alien.net on Sun, Jul 21, 2002 at 18:15:23 -0400
On 2002.07.21 18:15 Matthew Dharm wrote:
> These two BK patches fix two instances where a command is issued with an
> incorrect transfer length. The first is in the probing code... the section
> where we make the second INQUIRY request for the full INQUIRY data. The
> second is in sd.c where the MODE_SENSE request is issued.
>
[snip]
> diff -Nru a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> --- a/drivers/scsi/sd.c Sun Jul 21 00:55:44 2002
> +++ b/drivers/scsi/sd.c Sun Jul 21 00:55:44 2002
> @@ -1102,7 +1102,7 @@
> SRpnt->sr_data_direction = SCSI_DATA_READ;
>
> scsi_wait_req(SRpnt, (void *) cmd, (void *) buffer,
> - 512, SD_TIMEOUT, MAX_RETRIES);
> + 255, SD_TIMEOUT, MAX_RETRIES);
>
> the_result = SRpnt->sr_result;
>
Matt,
is asking for an odd number of bytes a good idea? There have been problems
with doing so on OnStream tape drives...
Thanks, Willem Riede.
next prev parent reply other threads:[~2002-07-21 22:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-21 22:15 2 PATCHES: fix request_tranferlength Matthew Dharm
2002-07-21 22:52 ` Willem Riede [this message]
2002-07-22 0:05 ` Matthew Dharm
2002-07-22 1:24 ` Kurt Garloff
2002-07-27 22:07 ` Matthew Dharm
2002-07-29 15:18 ` Alan Cox
2002-07-29 16:00 ` Randy.Dunlap
2002-07-29 16:50 ` Kurt Garloff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020721225233.GG7700@linnie.riede.org \
--to=wrlk@riede.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox