Re: 2 PATCHES: fix request_tranferlength

[Matthew Dharm <mdharm-scsi@one-eyed-alien.net>]

[-- Attachment #1: Type: text/plain, Size: 1762 bytes --]

We're asking for an odd number of bytes in the command... this just affects
the tranfer length field.  It doesn't actually change the command sent.

Also, this is the sd.c driver -- SCSI disks.  OnStream _tape_ drives are
unaffected by this change. :)

Matt

On Sun, Jul 21, 2002 at 06:52:33PM -0400, Willem Riede wrote:
> On 2002.07.21 18:15 Matthew Dharm wrote:
> > These two BK patches fix two instances where a command is issued with an
> > incorrect transfer length.  The first is in the probing code... the section
> > where we make the second INQUIRY request for the full INQUIRY data.  The
> > second is in sd.c where the MODE_SENSE request is issued.
> > 
> [snip]
> > diff -Nru a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> > --- a/drivers/scsi/sd.c	Sun Jul 21 00:55:44 2002
> > +++ b/drivers/scsi/sd.c	Sun Jul 21 00:55:44 2002
> > @@ -1102,7 +1102,7 @@
> >  	SRpnt->sr_data_direction = SCSI_DATA_READ;
> >  
> >  	scsi_wait_req(SRpnt, (void *) cmd, (void *) buffer,
> > -		      512, SD_TIMEOUT, MAX_RETRIES);
> > +		      255, SD_TIMEOUT, MAX_RETRIES);
> >  
> >  	the_result = SRpnt->sr_result;
> >  
> Matt, 
> 
> is asking for an odd number of bytes a good idea? There have been problems
> with doing so on OnStream tape drives...
> 
> Thanks, Willem Riede.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.net 
Maintainer, Linux USB Mass Storage Driver

I'm seen in many forms.  Now open your mouth.  It's caffeine time.
					-- Cola Man to Greg
User Friendly, 10/28/1998

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]