From: Rusty Russell <rusty@rustcorp.com.au>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>, linux-scsi@vger.kernel.org
Subject: Re: [TRIVIAL] warning cleanup for drivers_scsi_qla1280.c
Date: Thu, 08 Aug 2002 12:12:51 +1000 [thread overview]
Message-ID: <20020808032826.3478A455C@lists.samba.org> (raw)
In-Reply-To: Your message of "07 Aug 2002 12:37:05 +0100." <1028720225.18156.246.camel@irongate.swansea.linux.org.uk>
In message <1028720225.18156.246.camel@irongate.swansea.linux.org.uk> you write
:
> On Wed, 2002-08-07 at 04:59, Rusty Trivial Russell wrote:
> > [ Removes the unused warning, and since qla1280_do_dpc is only called when
> > version < 2.1.95 anyway, makes the whole thing conditional ]
> >
>
> General policy - rip out version ifdefs unless the driver has a
> maintainer who actively objects ?
Hm, I wouldn't accept a patch to Trivial which just ripped them out.
If it was part of a larger cleanup, then sure. In this case it
doesn't change code, it just simplifies it as well as the easiest way
of fixing the warning.
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2002-08-08 2:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-07 3:59 [TRIVIAL] warning cleanup for drivers_scsi_qla1280.c Rusty Trivial Russell
2002-08-07 11:37 ` Alan Cox
2002-08-07 11:12 ` Steve Ralston
2002-08-07 13:24 ` Alan Cox
2002-08-08 2:12 ` Rusty Russell [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-08-20 8:33 Rusty Trivial Russell
2002-12-16 6:43 Rusty Trivial Russell
2003-02-06 3:00 Rusty Trivial Russell
2003-06-23 6:47 Rusty Trivial Russell
2003-06-23 8:45 ` Christoph Hellwig
2003-06-23 8:51 ` Jes Sorensen
2003-06-23 9:27 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020808032826.3478A455C@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-scsi@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox