From: Rusty Trivial Russell <rusty@rustcorp.com.au>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: Jes Sorensen <jes@wildopensource.com>, linux-scsi@vger.kernel.org
Subject: [TRIVIAL] warning cleanup for drivers_scsi_qla1280.c
Date: Mon, 23 Jun 2003 16:47:25 +1000 [thread overview]
Message-ID: <20030623070135.AF6A72C292@lists.samba.org> (raw)
[ This function is unused if kernel > 2.1.95, so put #ifdef around whole thing
to avoid warning. --RR ]
From: Eric Sandeen <sandeen@sgi.com>
--- trivial-2.4.22-pre1/drivers/scsi/qla1280.c.orig 2003-06-23 16:39:22.000000000 +1000
+++ trivial-2.4.22-pre1/drivers/scsi/qla1280.c 2003-06-23 16:39:22.000000000 +1000
@@ -312,7 +312,9 @@
STATIC int qla1280_return_status( sts_entry_t *sts, Scsi_Cmnd *cp);
STATIC void qla1280_removeq(scsi_lu_t *q, srb_t *sp);
STATIC void qla1280_mem_free(scsi_qla_host_t *ha);
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,1,95)
static void qla1280_do_dpc(void *p);
+#endif
#ifdef QLA1280_UNUSED
static void qla1280_set_flags(char * s);
#endif
@@ -1611,17 +1613,12 @@
* "host->can_queue". This can cause a panic if we were in our interrupt
* code .
**************************************************************************/
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,1,95)
static void qla1280_do_dpc(void *p)
{
scsi_qla_host_t *ha = (scsi_qla_host_t *) p;
-#if LINUX_VERSION_CODE > KERNEL_VERSION(2,1,95)
- unsigned long cpu_flags = 0;
-#endif
COMTRACE('p')
-#if LINUX_VERSION_CODE > KERNEL_VERSION(2,1,95)
- spin_lock_irqsave(&io_request_lock, cpu_flags);
-#endif
if (ha->flags.isp_abort_needed)
qla1280_abort_isp(ha);
@@ -1631,10 +1628,8 @@
if (ha->done_q_first)
qla1280_done(ha, (srb_t **)&ha->done_q_first, (srb_t **)&ha->done_q_last);
ha->flags.dpc_sched = FALSE;
-#if LINUX_VERSION_CODE > KERNEL_VERSION(2,1,95)
- spin_unlock_irqrestore(&io_request_lock, cpu_flags);
-#endif
}
+#endif /* LINUX_VERSION_CODE < KERNEL_VERSION(2,1,95) */
/**************************************************************************
* qla1280_device_queue_depth
--
What is this? http://www.kernel.org/pub/linux/kernel/people/rusty/trivial/
Don't blame me: the Monkey is driving
File: Eric Sandeen <sandeen@sgi.com>: warning cleanup for drivers_scsi_qla1280.c
next reply other threads:[~2003-06-23 6:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-23 6:47 Rusty Trivial Russell [this message]
2003-06-23 8:45 ` [TRIVIAL] warning cleanup for drivers_scsi_qla1280.c Christoph Hellwig
2003-06-23 8:51 ` Jes Sorensen
2003-06-23 9:27 ` Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2003-02-06 3:00 Rusty Trivial Russell
2002-12-16 6:43 Rusty Trivial Russell
2002-08-20 8:33 Rusty Trivial Russell
2002-08-07 3:59 Rusty Trivial Russell
2002-08-07 11:37 ` Alan Cox
2002-08-07 11:12 ` Steve Ralston
2002-08-07 13:24 ` Alan Cox
2002-08-08 2:12 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030623070135.AF6A72C292@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=jes@wildopensource.com \
--cc=linux-scsi@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox